Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 268237 - =app-emulation/kvm-85-r1: pre-stripped files found (patch provided)
Summary: =app-emulation/kvm-85-r1: pre-stripped files found (patch provided)
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Daniel Gryniewicz (RETIRED)
Depends on:
Blocks: prestripped
  Show dependency tree
Reported: 2009-05-02 04:16 UTC by Kevin Pyle
Modified: 2009-05-14 14:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Patch to kvm-85-r1 ebuild to request that upstream build process not strip binaries (kvm-85-nostrip.ebuild.patch,772 bytes, patch)
2009-05-02 04:18 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pyle 2009-05-02 04:16:14 UTC
Gentoo ebuilds for qemu and kvm have had a sed invocation to prevent stripping for quite some time.  Recently, upstream added a configure option to disable stripping.  As a side effect of the changes made upstream to support this option, the Gentoo sed call no longer prevents stripping.  Thus, binaries which previously were not stripped are now stripped.

The fix is to change the ebuild to use the new mechanism to ask the build process not to strip binaries.  I will attach a patch to do this.

Before applying this patch, merging the build results in the following:
 * QA Notice: Pre-stripped files found:
 * /usr/bin/kvm-nbd
 * /usr/bin/kvm-img
 * /usr/bin/kvm
 * /usr/bin/qemu-io
 * /usr/share/kvm/openbios-ppc
 * /usr/share/kvm/openbios-sparc64
 * /usr/share/kvm/openbios-sparc32

After applying this patch, merging the build produces the following:
 * QA Notice: Pre-stripped files found:
 * /usr/share/kvm/openbios-ppc
 * /usr/share/kvm/openbios-sparc64
 * /usr/share/kvm/openbios-sparc32
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment

The OpenBIOS files are bundled in the tarball.
Comment 1 Kevin Pyle 2009-05-02 04:18:39 UTC
Created attachment 190093 [details, diff]
Patch to kvm-85-r1 ebuild to request that upstream build process not strip binaries

This patch removes the now-ineffective sed call that once prevented stripping, and adds an argument to the upstream configure script to ask that it not strip binaries.  This has the useful side effect that when the upstream configure script prints its strip setting, that value is consistent with what actually occurs.
Comment 2 Carlo Marcelo Arenas Belon 2009-05-03 17:59:20 UTC
To remove the OpenBIOS pre-stripped BLOBs which will go unused otherwise (there is no support for SPARC or PPC in kvm's userspace ebuild) there used to be also a patch "09_all_qemu-no-blobs.patch" which was dropped from the last patchset.

an alternative would be to enable (assumming support for it from emerge is provided, as it is for x86 and amd64) of :


this also has the sideffect of removing the scary warning about executable stacks in those binaries which asks for bugs to be filed and that will be otherwise bogus
Comment 3 Daniel Gryniewicz (RETIRED) gentoo-dev 2009-05-14 14:41:27 UTC
Fixed in kvm-85-r2