Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 265425 - sys-apps/acl-2.2.47 has broken symlink handling
Summary: sys-apps/acl-2.2.47 has broken symlink handling
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 235016
  Show dependency tree
 
Reported: 2009-04-08 10:48 UTC by Radek Podgorny
Modified: 2010-01-22 21:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Radek Podgorny 2009-04-08 10:48:37 UTC
please, resolve the buggy acl-2.4.47.

as i've pointed in bug 235016, the 2.4.47 version has broken symlink handling. version 2.4.45 was fine.

see http://oss.sgi.com/bugzilla/show_bug.cgi?id=790 and http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=499076 for more info.

either include the patches found at the urls i've linked or put back the 2.4.45 version to portage. ...but un-stabilize 2.4.47 for sure!
Comment 1 Radek Podgorny 2009-04-08 11:37:26 UTC
...ewww, sorry, i meant 2.2.* versions.
Comment 2 SpanKY gentoo-dev 2009-05-29 23:54:37 UTC
the bugs arent cut and dry.  what changes exactly are you looking for ?

i see these two:
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/acl/libmisc/walk_tree.c.diff?r1=1.2;r2=1.3
http://oss.sgi.com/bugzilla/attachment.cgi?id=247
Comment 3 Radek Podgorny 2009-06-30 08:08:33 UTC
sorry for such late reply...

i've just tested both patches and only the second (http://oss.sgi.com/bugzilla/attachment.cgi?id=247) seems to work... ...please include to portage.
Comment 4 SpanKY gentoo-dev 2009-07-02 01:29:43 UTC
well, it's good you waited as the upstream report was updated in the last week to include the change.  ive added the commit that actually went into acl.git.

http://git.savannah.gnu.org/cgit/acl.git/commit/?id=1a80c89ee88357137b598fa3357b5
http://git.savannah.gnu.org/cgit/acl.git/commit/?id=63451a06b7484d220750ed8574d3e
Comment 5 Emil Wojak 2009-10-01 20:36:27 UTC
The feature still remains broken in sys-apps/acl-2.2.47 and 2.2.47-r1.
Here's a simple test I did:
-------------------------------------
mwojak@Kefiron ~ $ mkdir acltest
mwojak@Kefiron ~ $ cd acltest
mwojak@Kefiron ~/acltest $ mkdir dir{1,2}
mwojak@Kefiron ~/acltest $ touch dir{1,2}/file
mwojak@Kefiron ~/acltest $ ln -s ../dir2 dir1/
mwojak@Kefiron ~/acltest $ ls -lR
.:
razem 0
drwxr-xr-x 2 mwojak users 96 10-01 22:11 dir1
drwxr-xr-x 2 mwojak users 72 10-01 22:11 dir2

./dir1:
razem 0
lrwxrwxrwx 1 mwojak users 7 10-01 22:11 dir2 -> ../dir2
-rw-r--r-- 1 mwojak users 0 10-01 22:11 file

./dir2:
razem 0
-rw-r--r-- 1 mwojak users 0 10-01 22:11 file
mwojak@Kefiron ~/acltest $ setfacl -R -P -m u:mwojak:rwX dir1
mwojak@Kefiron ~/acltest $ ls -l dir2/file
-rw-rw-r--+ 1 mwojak users 0 10-01 22:11 dir2/file
-------------------------------------
Look at the plus sign next to dir2/file permissions - it shouldn't be there. This bug is quite dangerous IMHO. Consider using root privileges for applying ACLs recursively on a user's home directory with Wine setup. The whole system gets updated because ~/.wine/dosdevices/z: points to /, which is not funny :]
Comment 6 Brandon Philips 2009-12-23 20:12:00 UTC
(In reply to comment #4)
> well, it's good you waited as the upstream report was updated in the last week
> to include the change. 

FWIW, the new upstream releases are over here: 
 https://savannah.nongnu.org/files/?group=attr

The latest version is 2.2.49.
Comment 7 Brandon Philips 2010-01-22 21:50:11 UTC
(In reply to comment #6)
> FWIW, the new upstream releases are over here: 
>  https://savannah.nongnu.org/files/?group=attr

And of course I meant this:
 https://savannah.nongnu.org/files/?group=acl

acl not attr.