Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 264730 - emerge-delta-webrsync <-> tarsync DEPEND shouldn't be platform-related
Summary: emerge-delta-webrsync <-> tarsync DEPEND shouldn't be platform-related
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Zac Medico
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2009-04-03 08:14 UTC by Michał Górny
Modified: 2010-04-13 17:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Example ebuild with USEflag. (emerge-delta-webrsync-3.5.1-r2.ebuild,1.02 KB, text/plain)
2009-04-03 08:15 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-04-03 08:14:51 UTC
=emerge-delta-webrsync-3.5.1-r2 depends on tarsync like so:
    x86? ( app-arch/tarsync )

I think this is really incorrect. On one hand, x86 user may not want to use tarsync anyway. On the other, tarsync works fine with other archs (amd64 for sure). And if user has tarsync installed, eds will use it anyway.

So what's the sense of forcing user to put tarsync into world file? I think tarsync should get his own USEflag in eds, allowing users of any arch to choose whether they want it or not.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-04-03 08:15:44 UTC
Created attachment 187162 [details]
Example ebuild with USEflag.
Comment 2 Zac Medico gentoo-dev 2009-04-03 21:54:29 UTC
If I do what you suggest then I'll have to do a keyword request for tarsync on all the archs that emerge-delta-webrsync has keywords for.

Since the tarsync upstream isn't really active and it doesn't have lzma support yet, I'm thinking about porting tarsync to python (and adding lzma support in the process). It shouldn't be much work and when it's python based I can automatically give it keywords on all archs (since python code is extremely portable all archs support python).
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-04-04 09:54:35 UTC
(In reply to comment #2)
> If I do what you suggest then I'll have to do a keyword request for tarsync on
> all the archs that emerge-delta-webrsync has keywords for.

So maybe just add amd64 (and other arches tarsync has keywords for) to that DEPEND?
Comment 4 Zac Medico gentoo-dev 2009-04-05 05:23:10 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > If I do what you suggest then I'll have to do a keyword request for tarsync on
> > all the archs that emerge-delta-webrsync has keywords for.
> 
> So maybe just add amd64 (and other arches tarsync has keywords for) to that
> DEPEND?

That will require a stable request on amd64. I'd prefer to write a python version and do a stable request on that instead. Once that's done, I can remove tarsync from the tree.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-07-12 23:45:48 UTC
(In reply to comment #4)
> That will require a stable request on amd64. I'd prefer to write a python
> version and do a stable request on that instead. Once that's done, I can remove
> tarsync from the tree.

And how is your python version? (;
Comment 6 Zac Medico gentoo-dev 2009-07-16 22:06:28 UTC
Thanks for reminding me. Hopefully I'll do it soon. :)
Comment 7 Brian Harring (RETIRED) gentoo-dev 2010-04-12 10:25:33 UTC
(In reply to comment #6)
> Thanks for reminding me. Hopefully I'll do it soon. :)

Skip it.  I originally wrote tarsync in python, I went to c since I couldn't make it fast enough to warrant it (full untar + rsync was faster)... tarfile is just a freaking slow implementation.  A libarchive based version (pyarchive bindings specifically) is my long term intention.

Related, tarsync upstream is active once again...
Comment 8 Zac Medico gentoo-dev 2010-04-12 22:35:38 UTC
I plan to remove the tarsync dep from emerge-delta-webrsync and show a elog message in pkg_postinst recommending to install it if it's not installed already.
Comment 9 Brian Harring (RETIRED) gentoo-dev 2010-04-13 03:13:24 UTC
(In reply to comment #8)
> I plan to remove the tarsync dep from emerge-delta-webrsync and show a elog
> message in pkg_postinst recommending to install it if it's not installed
> already.

Switch to a use flag of 'suggested' or 'speed' or equivalent imo... It really is worth the dep where possible.
Comment 10 Zac Medico gentoo-dev 2010-04-13 16:48:42 UTC
(In reply to comment #9)
> Switch to a use flag of 'suggested' or 'speed' or equivalent imo... It really
> is worth the dep where possible.

Then I'd have to go through hoops to mask it on archs that haven't keyworded tarsync. No thanks. What's really needed is an EAPI extension for 'suggested' dependencies (or introduce a global 'suggested' flag and hardcode support for it in repoman).

Anyway, I've removed the tarsync dep in cvs.
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-04-13 17:27:44 UTC
(In reply to comment #10)
> What's really needed is an EAPI extension for 'suggested'
> dependencies (or introduce a global 'suggested' flag and hardcode support for
> it in repoman).

…and then possibility of having multiple 'suggested' sets, then marking of RDEPENDs that could be changed without recompiling packages, etc., etc. IMO it's better to just leave it as is.