Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 259898 - Cleanup mercurial.eclass
Summary: Cleanup mercurial.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Highest normal (vote)
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 160565 255560
  Show dependency tree
 
Reported: 2009-02-22 13:43 UTC by Krzysztof Pawlik (RETIRED)
Modified: 2009-03-11 18:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mercurial.eclass.patch (mercurial.eclass.patch,5.80 KB, patch)
2009-02-22 14:29 UTC, Krzysztof Pawlik (RETIRED)
Details | Diff
mercurial.eclass.patch (mercurial.eclass.patch,5.82 KB, patch)
2009-03-07 16:38 UTC, Krzysztof Pawlik (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-22 13:43:37 UTC
Bug to help me track other mercurial.eclass related issues.

I'm working on heavy modifications of mercurial.eclass, expect patches attached to this bug soon.
Comment 1 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-22 14:29:41 UTC
Created attachment 182775 [details, diff]
mercurial.eclass.patch

mercurial.eclass path, changes:
 - fixed (hopefully) existing bugs
 - eclass documentation
 - general cleanup
Comment 2 Arne Babenhauserheide 2009-02-23 11:05:26 UTC
Against which version do you patch? (the patch failed for me in the tree as well as in my local version)
Comment 3 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-02-23 18:39:24 UTC
From the patch itself:

diff -u -r1.4 mercurial.eclass

Could you post output of patch with mercurial.eclass.rej file ?
Comment 4 Arne Babenhauserheide 2009-02-23 19:06:22 UTC
I don't work on the cvs but on my rsync tree mirror... 
Comment 5 Arne Babenhauserheide 2009-02-23 19:08:38 UTC
And the sync I just did fixed it. 
Comment 6 Arne Babenhauserheide 2009-02-28 14:15:08 UTC
I've been testing this patch, but it has teh disadvantage of not offering a Mercurial repository for packages. 

The packages might require being in a repository for building, though. 

For example the Mercurial setup.py checks the id of the repository to set its version dynamically. 

What is your reason for using archive instead of clone? 
Comment 7 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-03-07 16:38:57 UTC
Created attachment 184238 [details, diff]
mercurial.eclass.patch

This uses clone instead of export.
Comment 8 Arne Babenhauserheide 2009-03-09 12:46:20 UTC
With this patch, dev-util/mercurial-9999 builds again. 

Many thanks! 
Comment 9 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-03-09 20:08:57 UTC
(In reply to comment #8)
> With this patch, dev-util/mercurial-9999 builds again. 
> 
> Many thanks! 

Commited.
Comment 10 Arne Babenhauserheide 2009-03-11 08:18:09 UTC
I just spotted one minor point: 

In line 103 of the eclass the error message should be "hg clone failed" instead of "hg archive failed". 

103: "${WORKDIR}/${module}" || die "hg archive failed"


Also you don't need "rm -rf" to remove a Mercurial repository. A simple "rm -r" suffices (I don't know if that's relevant, though). 
Comment 11 Krzysztof Pawlik (RETIRED) gentoo-dev 2009-03-11 18:56:40 UTC
(In reply to comment #10)
> I just spotted one minor point: 
> 
> In line 103 of the eclass the error message should be "hg clone failed" instead
> of "hg archive failed". 
> 
> 103: "${WORKDIR}/${module}" || die "hg archive failed"

Thanks, fixed.