Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 257781 - app-text/hunspell-1.2.8 patches for IRIX
Summary: app-text/hunspell-1.2.8 patches for IRIX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All IRIX
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-05 15:01 UTC by Stuart Shelton
Modified: 2010-04-15 07:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes to allow hunspell to build on IRIX (hunspell-1.2.8.patch,8.45 KB, patch)
2009-02-05 15:03 UTC, Stuart Shelton
Details | Diff
Patch to allow hunspell-1.2.8 to build on IRIX (hunspell-1.2.8-irix.patch,4.36 KB, patch)
2009-06-30 10:12 UTC, Stuart Shelton
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Shelton 2009-02-05 15:01:14 UTC
Because the IRIX linker doesn't re-order objects to ensure that dependencies are met, the Makefile{.am,.in} files had to be altered, some of the debugging was just plain broken, and for some reason it didn't compile with only the C++ headers included so I had to include the C ones too...

Note that the final patch makes hunspell-1.2.8/tests/test.sh prefix-aware, but (since the shell doesn't expand "${EPREFIX}" in #! lines) this would probably have to be done in the ebuild - its included here for completeness.

(I also found that initially the test suite wouldn't run - due to being unable to find libhunspell-1.2.so.1.1 in any standard library paths.  Obviously, this starts working once the package is already installed - but for first time installs the .libs directory will also probably have to be added to the Makefile)
Comment 1 Stuart Shelton 2009-02-05 15:03:48 UTC
Created attachment 181035 [details, diff]
Fixes to allow hunspell to build on IRIX


(Note this patches Makefile.am, Makefile.in, and also Makefile.  The latter was really for testing)
Comment 2 Michael Haubenwallner (RETIRED) gentoo-dev 2009-02-05 15:20:37 UTC
(In reply to comment #0)
> linker doesn't re-order objects to ensure that dependencies are met,

This rings a bell in my brain-archive:

Are both binaries 'lorder' and 'tsort' available?

In very old Makefiles I've seen something linke this:

   ar q libx.a `lorder $(OBJS) | tsort`
   ld -o executable `lorder $(OBJS) | tsort`
Comment 3 Stuart Shelton 2009-02-06 11:21:24 UTC
No 'lorder' that I can see, unfortunately :(
Comment 4 Stuart Shelton 2009-06-30 10:12:05 UTC
Created attachment 196142 [details, diff]
Patch to allow hunspell-1.2.8 to build on IRIX


Here's a much better patch: Improvements to the MIPSpro wrapper have resolved the library order issues, and a closer look has revealed that the C++ system headers either do nothing or include the C headers if -LANG:libc_in_namespace_std is specified - although if this is not the case they should #error out, which wasn't happening either.  In any case, simply including the C headers seems to work.

This can be included with:

--- hunspell-1.2.8.ebuild
+++ hunspell-1.2.8.ebuild
@@ -30,6 +30,7 @@
        # to be placed in /usr/bin - this patch prefixes them with 'hunspell-'.
        # It modifies a Makefile.am file, hence eautoreconf.
        epatch "${FILESDIR}"/${PN}-1.2.2-renameexes.patch
+       [[ $CHOST == *-irix* ]] && epatch "${FILESDIR}"/${PN}-1.2.8-irix.patch
        eautoreconf
 }
 

This patch does not alter the test-suite at all.
Comment 5 Peter Volkov (RETIRED) gentoo-dev 2010-04-15 07:25:08 UTC
Looks like this issue was fixed upstream in 1.2.9 which is now in the tree. Please, check with 1.2.9 and reopen bug if it still fails for you. Thanks.