Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 256389 - Wikipedia Entries No Longer Visible in Amarok-1.4.X
Summary: Wikipedia Entries No Longer Visible in Amarok-1.4.X
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 261579 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-26 08:04 UTC by Nick Andrade
Modified: 2009-05-25 21:59 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
A patch implementing the fix described in the report. (amarok-1.4.10-wikipedia.patch,574 bytes, patch)
2009-01-26 08:06 UTC, Nick Andrade
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Andrade 2009-01-26 08:04:23 UTC
Amarok's context browser previously allowed users to view artist info in the Context tab of the Amarok 1.4 application.  Wikipedia made a change to their HTML which has broken this functionality (at least on the 1.4 line of Amarok, possibly other version).  

Reproducible: Always

Steps to Reproduce:
1. Open Amarok 1.4
2. Select a track by an artist with a Wikipedia page and begin to play it
3. Switch to the "Context" tab, then the artist tab

Actual Results:  
The wikipedia information box will be empty, below will be a list of different language for that page.  I've read that artists with only one language page may work, but most major artist have pages in several languages and will have the problem I'm describing.

Expected Results:  
A parsed version of the wikipedia page rendered in the context/artist tab.

The fix for this is very simple, edit contextbrowser.cpp and look for "firstHeading".  For Amarok 1.4.10, the line (4192) changes as follows:
from: m_wiki = m_wiki.mid( m_wiki.find( "<h1 class=\"firstHeading\">" ) );
to: m_wiki = m_wiki.mid( m_wiki.find( "<h1 id=\"firstHeading\" class=\"firstHeading\">" ) );

This general fix (adding the id=... string) should probably work on other versions of the Amarok 1.4.X line.  A big thanks to WarwickH on the Ubuntu bugzilla for finding the line (https://bugs.launchpad.net/ubuntu/+source/amarok/+bug/316140/).
Comment 1 Nick Andrade 2009-01-26 08:06:00 UTC
Created attachment 179748 [details, diff]
A patch implementing the fix described in the report.
Comment 2 Carsten Lohrke (RETIRED) gentoo-dev 2009-01-30 15:35:51 UTC
Synced to stable branch. Have fun with amarok-1.4.10_p20090130, -r1 respectively.
Comment 3 Petr Kusy 2009-02-03 22:37:25 UTC
Hi.
HOW can I edit contextbrowser.cpp? WHERE can I find it???
Petr
Comment 4 Oliver Schwabedissen 2009-04-09 04:33:24 UTC
This fix never went stable. The current version Amarok-1.4.10-r2 still has the wikipedia bug.
Comment 5 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2009-04-09 11:51:16 UTC
I'll check this during the "extended" weekend.
Comment 6 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2009-05-24 18:55:11 UTC
*** Bug 261579 has been marked as a duplicate of this bug. ***
Comment 7 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2009-05-25 21:59:51 UTC
amarok-1.4.10_p20090130-r2 is going to be stabilized soon, so closing