255773 – x11-themes/gtk-engines bundles an internal copy of liblua

Bug 255773 - x11-themes/gtk-engines bundles an internal copy of liblua

Summary: x11-themes/gtk-engines bundles an internal copy of liblua

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	bundled-libs
	Show dependency tree

Reported:	2009-01-21 18:31 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2009-09-03 10:56 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Use system liblua for Lua gtk engine (2.16.1 patch) (gtk-engines-2.16.1-use-system-lua.patch,2.67 KB, patch) 2009-08-31 11:30 UTC, Ihar Hrachyshka	Details \| Diff
Use system liblua for Lua gtk engine (2.18.2 patch) (gtk-engines-2.18.2-use-system-lua.patch,2.62 KB, patch) 2009-08-31 11:30 UTC, Ihar Hrachyshka	Details \| Diff
Updated gtk-engines-2.16.1-r1 ebuild (gtk-engines-2.16.1-r1.ebuild,849 bytes, text/plain) 2009-08-31 11:31 UTC, Ihar Hrachyshka	Details
Updated gtk-engines-2.18.2-r1 ebuild (gtk-engines-2.18.2-r1.ebuild,1.04 KB, text/plain) 2009-08-31 11:31 UTC, Ihar Hrachyshka	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-01-21 18:31:29 UTC

Err... uh? No seriously...

Comment 1 Ihar Hrachyshka 2009-08-31 11:30:25 UTC

Created attachment 202786 [details, diff]
Use system liblua for Lua gtk engine (2.16.1 patch)

Comment 2 Ihar Hrachyshka 2009-08-31 11:30:43 UTC

Created attachment 202787 [details, diff]
Use system liblua for Lua gtk engine (2.18.2 patch)

Comment 3 Ihar Hrachyshka 2009-08-31 11:31:18 UTC

Created attachment 202788 [details]
Updated gtk-engines-2.16.1-r1 ebuild

Comment 4 Ihar Hrachyshka 2009-08-31 11:31:34 UTC

Created attachment 202789 [details]
Updated gtk-engines-2.18.2-r1 ebuild

Comment 5 Ihar Hrachyshka 2009-08-31 11:32:55 UTC

Seems that we can't do much upstream because gtk-engines is a part of GNOME, and upstream doesn't like external deps like liblua.

Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev

2009-08-31 12:00:29 UTC

(In reply to comment #5)
> Seems that we can't do much upstream because gtk-engines is a part of GNOME,
> and upstream doesn't like external deps like liblua.
> 

that doesn't mean they should not allow using the system lib. If you could enhance your patch to have a --with-lua=system|local-copy or something like that, it would be perfect for inclusion.

Comment 7 Ihar Hrachyshka 2009-08-31 13:24:27 UTC

You can find my reworked patch posted for upstream bugzilla here: http://bugzilla.gnome.org/show_bug.cgi?id=593674

Comment 8 Ihar Hrachyshka 2009-08-31 18:12:24 UTC

I've committed the patch for --with-system-lua configure option to upstream git with my gnome account so you can use the option for next gtk-engines-2.20.* releases. As for now, just add my patches to gentoo cvs. Thanks.

Comment 9 Romain Perier (RETIRED) gentoo-dev

2009-08-31 19:11:08 UTC

+*gtk-engines-2.18.2-r1 (31 Aug 2009)
+
+  31 Aug 2009; Romain Perier <mrpouet@gentoo.org>
+  +gtk-engines-2.18.2-r1.ebuild, +files/gtk-engines-2.18.2-system-lua.patch:
+  Fix bug #255773, use liblua system library instead of embedded version,
+  patch import from upstream bug #593674, thanks to Ihar Hrachyshka
+  <ihar.hrachyshka@gmail.com> for his work

Fixed into the main tree, thanks for your patch :)

Comment 10 Romain Perier (RETIRED) gentoo-dev

2009-09-03 10:56:30 UTC

A fixed version of this patch was send on upstream
see http://bugzilla.gnome.org/show_bug.cgi?id=594014

for more details