Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 254615 - net-misc/openssh-5.1_p1-r3 does not honor prefix
Summary: net-misc/openssh-5.1_p1-r3 does not honor prefix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-12 10:02 UTC by Fabian Groffen
Modified: 2009-01-21 05:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2009-01-12 10:02:30 UTC
checking for ls... /usr/bin/ls
checking for netstat... /usr/bin/netstat
checking for arp... /usr/sbin/arp
checking for ifconfig... /sbin/ifconfig
checking for jstat... no
checking for ps... /usr/bin/ps
checking for sar... /usr/bin/sar
checking for w... /usr/bin/w
checking for who... /usr/bin/who
checking for last... /usr/bin/last
checking for lastlog... no
checking for df... /usr/bin/df
checking for vmstat... /usr/bin/vmstat
checking for uptime... /usr/bin/uptime
checking for ipcs... /usr/bin/ipcs
checking for tail... /usr/bin/tail


I say some of that stuff could come straight from the prefix, iso the host.
Comment 1 Fabian Groffen gentoo-dev 2009-01-18 12:06:47 UTC
darkside, any luck with that configure hack you were working on?
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-01-19 16:09:58 UTC
@base-system:

We have a simple sed ready for this ebuild that looks like this:

sed -i -e 's:^PATH=/:#PATH=/:' configure

So, if you look in the configure script. Line 18415, you see that upstream has a reason for resetting the PATH. They claim it is for security reasons. My claim is that we should be able to always trust the PATH given to us by portage itself. While not strictly a problem in the gentoo-x86 tree, we are asking for your inclusion into the ebuild for us. If not, it will be a local change in the Prefix tree. Please let us know. Thanks in advance.
Comment 3 SpanKY gentoo-dev 2009-01-19 16:13:08 UTC
yes, removing the PATH reset for everyone is OK ... feel free to commit that
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-01-21 05:05:55 UTC
Index: openssh-5.1_p1-r3.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-misc/openssh/openssh-5.1_p1-r3.ebuild,v
retrieving revision 1.1
diff -u -r1.1 openssh-5.1_p1-r3.ebuild
--- openssh-5.1_p1-r3.ebuild    9 Jan 2009 02:37:33 -0000 1.1
+++ openssh-5.1_p1-r3.ebuild    21 Jan 2009 05:00:07 -0000
@@ -96,6 +96,9 @@
       epatch "${FILESDIR}"/${P}-escaped-banner.patch #244222
       epatch "${FILESDIR}"/${P}-better-ssp-check.patch
 
+      # Disable PATH reset, trust what portage gives us. bug 254615
+      sed -i -e 's:^PATH=/:#PATH=/:' configure || die
+
       eautoreconf
 }

Thanks for the 'ok' on this one ;) reso:fixed.

(I have tested this already in Gentoo Prefix, it works. It should be auto-synced tomorrow. I tested on Gentoo Linux as well - looks good)