Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 251424 - app-text/jpdftweak-0.9 - new ebuild
Summary: app-text/jpdftweak-0.9 - new ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL: http://jpdftweak.sourceforge.net
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-18 09:42 UTC by Jiri Tyr
Modified: 2009-02-21 07:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
jpdftweak-0.9.ebuild (jpdftweak-0.9.ebuild,1.12 KB, text/plain)
2008-12-18 09:43 UTC, Jiri Tyr
Details
jpdftweak-0.9.ebuild (jpdftweak-0.9.ebuild,1.08 KB, text/plain)
2008-12-18 15:42 UTC, Jiri Tyr
Details
Patch against Attachment #175738 (jpdftweak.patch,1.06 KB, patch)
2008-12-18 18:44 UTC, Serkan Kaba (RETIRED)
Details | Diff
Patch against Attachment #175738 (jpdftweak.patch,1.05 KB, patch)
2008-12-18 19:05 UTC, Serkan Kaba (RETIRED)
Details | Diff
jpdftweak-0.9.ebuild (jpdftweak-0.9.ebuild,992 bytes, text/plain)
2008-12-26 19:01 UTC, Jiri Tyr
Details
jpdftweak-0.9.ebuild (jpdftweak-0.9.ebuild,982 bytes, text/plain)
2008-12-28 15:28 UTC, Jiri Tyr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Tyr 2008-12-18 09:42:51 UTC
jPDF Tweak is a Java Swing application that can combine, split, rotate, reorder, watermark, encrypt, sign, and otherwise tweak PDF files.
Comment 1 Jiri Tyr 2008-12-18 09:43:24 UTC
Created attachment 175688 [details]
jpdftweak-0.9.ebuild

Ebuild for the jpdftweak-0.9.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2008-12-18 14:15:49 UTC
Reassigning...

Jiri, please wrap quotation-marks around each ${S}:

${S} should become "${S}"
Comment 3 Serkan Kaba (RETIRED) gentoo-dev 2008-12-18 14:57:17 UTC
(In reply to comment #1)
> Created an attachment (id=175688) [edit]
> jpdftweak-0.9.ebuild
> 
> Ebuild for the jpdftweak-0.9.
> 

* java-pkg_jar-from takes a third argument as the name of the symlink.
* ant-core dependency is handled by eclasses.
* make_desktop_entry should take just ${PN} as 1st param.
* dodoc should die in case of an error.
Comment 4 Jiri Tyr 2008-12-18 15:42:23 UTC
Created attachment 175738 [details]
jpdftweak-0.9.ebuild

Some corrections. Thanks to Serkan Kaba.
Comment 5 Serkan Kaba (RETIRED) gentoo-dev 2008-12-18 18:44:21 UTC
Created attachment 175773 [details, diff]
Patch against Attachment #175738 [details]

I'm adding a patch against your latest ebuild that fixes more issues that I, repoman and java-dep-check discovered.

* GPL is not a valid license in ${PORTDIR}/licenses.
* IUSE should be defined even if it's empty.
* dev-java/bcmail dev-java/bcprov are indirect dependencies.
* Proguard is just used in building static jar.
* cd should die on error.
Comment 6 Serkan Kaba (RETIRED) gentoo-dev 2008-12-18 19:05:41 UTC
Created attachment 175779 [details, diff]
Patch against Attachment #175738 [details]

This fixes another issue. You're already at $WORKDIR after src_unpack. Also please consider talking us on #gentoo-java @FreeNode and contibuting your ebuild(s) to overlays.

Thanks,
Serkan
Comment 7 Jiri Tyr 2008-12-26 19:01:11 UTC
Created attachment 176462 [details]
jpdftweak-0.9.ebuild

Some corrections for jpdftweak-0.9. Thanks to Serkan.
Comment 8 Serkan Kaba (RETIRED) gentoo-dev 2008-12-26 22:11:56 UTC
(In reply to comment #7)
> Created an attachment (id=176462) [edit]
> jpdftweak-0.9.ebuild
> 
> Some corrections for jpdftweak-0.9. Thanks to Serkan.
> 

Just a tiny bit I didn't notice before
doXXX calls do not need the $S prefix since you're already located at $S in src_install
Comment 9 Jiri Tyr 2008-12-28 15:28:06 UTC
Created attachment 176616 [details]
jpdftweak-0.9.ebuild

Removed the ${S} from all doxxx commands.
Comment 10 Serkan Kaba (RETIRED) gentoo-dev 2009-01-01 08:20:27 UTC
(In reply to comment #9)
> Created an attachment (id=176616) [edit]
> jpdftweak-0.9.ebuild
> 
> Removed the ${S} from all doxxx commands.
> 

Looks good except the desktop file looks for an icon that's KDE only. Maybe we could pass that until upstream has a proper logo/icon. Also you may consider getting involved via #gentoo-java @ FreeNode or posting to Java ML (gentoo-java@lists.gentoo.org) where you may get more guidance. Also you may get access to our overlays to maintain it yourself.

Thanks,
Serkan
Comment 11 Serkan Kaba (RETIRED) gentoo-dev 2009-02-21 07:00:02 UTC
Added to portage. Thanks for the ebuild.