Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 250170 - gnustep-apps/cynthiune: fails with forced --as-needed
Summary: gnustep-apps/cynthiune: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Gnustep project
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2008-12-07 14:37 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2008-12-09 17:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (cynthiune-0.9.5-r1:20081207-033856.log,47.38 KB, text/plain)
2008-12-07 14:38 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-07 14:37:37 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-07 14:38:56 UTC
Created attachment 174556 [details]
Build log
Comment 2 Fabian Groffen gentoo-dev 2008-12-07 14:45:39 UTC
to me it just looks like it fails to compile regardless of as-needed, or am I missing something?
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-12-07 14:50:28 UTC
If you look at the linking line:

i686-pc-linux-gnu-gcc  -rdynamic  -LFrameworks/Cynthiune/Cynthiune.framework/Versions/Current -lCynthiune ...

-lCynthiune is passed before any object file. I think it's what Bernard referred to in bug #249507 as ADDITIONAL_*.

This seems to be common for other packages too, so it should probably be fixed in the same way across the ebuilds.
Comment 4 Fabian Groffen gentoo-dev 2008-12-07 14:53:28 UTC
ahh, let me see what I can do about that.
Comment 5 Fabian Groffen gentoo-dev 2008-12-07 15:42:08 UTC
problem with Cynthiune is that it is a framework, so the offending "lib" is a framework, not a library.  They add this to the LDFLAGS:

frameworks.make:
ifeq (mingw32, $(GNUSTEP_TARGET_OS))
ADDITIONAL_GUI_LIBS += -L$(FRAMEWORKS_DIRS)/../../Cynthiune.app $(_ldflags)
else
ADDITIONAL_LDFLAGS += $(_ldflags)
endif

Perhaps we could slightly hack in this case such that the -lCynthiune goes in ADDITIONAL_GUI_LIBS, while the rest goes in ADDITIONAL_LDFLAGS.  I suspect upstream is not going to be amused.  Your log shows it's been done right through the system, and only fails for this framework thing.
Comment 6 Bernard Cafarelli gentoo-dev 2008-12-09 17:12:36 UTC
Indeed that looks the correct way to clean this. I've split $(_ldflags)
 in $(_ldflags) and $(_libs), added to revbumped ebuild just in case it breaks something ;)

Upstream looks mostly dead (I hope melodie becomes useful before we can't maintain this one anymore)