Bug 249625 – media-libs/wxsvg bundles an internal copy of expat

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2008-12-02 16:54:04 UTC]

Not sure about the version, anyway it stinks, would be a nice idea to make it use the system copy if possible.

[Comment 1 Arttu Valo 2008-12-03 12:35:21 UTC]

Created attachment 174157 [details, diff]
patch which changes wxsvg to use external expat

Patch which changes wxSVG to use external expat (I hope).

[Comment 2 Arttu Valo 2008-12-03 12:44:42 UTC]

Created attachment 174159 [details]
ebuild to go with the expat patch

Ebuild which applies the above patch and hopefully works with multilib too.

Only tested briefly on amd64 with dvdstyler (only thing in portage which depended on wxsvg), so not sure if it really works.

[Comment 3 Ryan Hill (RETIRED) 2009-01-18 02:27:13 UTC]

thanks for the patch.  i'd like to fix this in a way that can be sent upstream so everyone benefits.  adding an option to configure to optionally build against the system expat library seems like it would have the best chance of being accepted.  can you expand it to do that?

i've also emailed upstream to make them aware of the issue.

[Comment 4 Arttu Valo 2009-04-06 23:20:46 UTC]

Sorry, I had apparently forgotten to tick the email CC checkbox so I have missed the question in comment #3 until (accidentally) noticing it now.

I'll try to squeeze out some autotooleeze for the wxsvg-1.0 ebuild over the Easter if the bundled copies are still an issue.

[Comment 5 Arttu Valo 2009-05-08 22:10:03 UTC]

Created attachment 190715 [details]
my first proper AC function definition (a world premiere?)

Sort of a "hello world", my first m4 script piece which just defines the simple function I use to munch the argument about libexpat.la's whereabouts

[Comment 6 Arttu Valo 2009-05-08 22:11:00 UTC]

Created attachment 190716 [details, diff]
a patch which uses the m4 attached above

[Comment 7 Arttu Valo 2009-05-08 22:15:12 UTC]

Created attachment 190718 [details, diff]
patch for the wxsvg-1.0.ebuild itself

Bumps to EAPI="2", does what little was needed to use the patch and m4 above. My variable and function naming is horrendous, but I really don't have a clue what people would want them to be called, so picked strings that are hopefully easy to search-and-replace. Maybe I should've just called them billybob and joe?

[Comment 8 Arttu Valo 2009-05-08 22:15:45 UTC]

Comment on attachment 174159 [details]
ebuild to go with the expat patch

obsoleting the beta versions stuff

[Comment 9 Ryan Hill (RETIRED) 2010-02-18 02:02:45 UTC]

Created attachment 220127 [details, diff]
wxsvg-external-expat.diff

sorry about the long delay.  this will fail if someone deletes their .la files, which is all the rage these days.

what about the attached?

[Comment 10 Ryan Hill (RETIRED) 2010-02-19 22:55:05 UTC]

this seems to pass any testing i've tried.  diego, you're the autotools expert, how does it look?

[Comment 11 Diego Elio Pettenò (RETIRED) 2010-02-20 00:43:38 UTC]

Looks perfectly fine to me.

[Comment 12 Ryan Hill (RETIRED) 2010-02-20 05:30:43 UTC]

Fixed in 1.0.2-r1, thanks.