Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 248934 - net-p2p/mldonkey + >dev-lang/ocaml-3.10 - hangs interactively asking "Do you want this script to try to download and install ocaml LOCALLY in mldonkey directory ?"
Summary: net-p2p/mldonkey + >dev-lang/ocaml-3.10 - hangs interactively asking "Do you ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-26 19:22 UTC by Jeroen Roovers (RETIRED)
Modified: 2010-09-29 13:35 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-p2p/mldonkey/files/mldonkey-3.0.0_ocaml-3.11.x.patch (mldonkey-3.0.0_ocaml-3.11.x.patch,566 bytes, patch)
2009-11-02 20:43 UTC, Jonathan-Christofer Demay
Details | Diff
mldonkey-3.0.0.ebuild (mldonkey-3.0.0.ebuild,4.63 KB, text/plain)
2009-11-09 14:20 UTC, Billy DeVincentis
Details
Files for overlay (mldonkey.tar.gz,13.81 KB, text/plain)
2009-11-09 14:22 UTC, Billy DeVincentis
Details
mldonkey ebuild patch (mldonkey-3.0.0-ebuild.patch,402 bytes, patch)
2009-12-07 13:43 UTC, Denis Kaganovich
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2008-11-26 19:22:51 UTC
Should probably DEPEND on <=dev-lang/ocaml-3.10
Comment 1 Raúl Porcel (RETIRED) gentoo-dev 2008-11-27 10:14:57 UTC
Won't that make an upgrade/downgrade loop?
Comment 2 spiralvoice 2009-01-20 21:23:37 UTC
About which Ocaml version are we talking about here?
New MLDonkey 2.9.7 can be compiled using Ocaml 3.11.0
Comment 3 Raúl Porcel (RETIRED) gentoo-dev 2009-02-09 14:35:04 UTC
Jer?
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2009-02-09 16:00:29 UTC
I guess it was <=2.9.6.
Comment 5 Kamen Dokov 2009-09-21 08:17:42 UTC
    Checking Ocaml compiler.
--------------------------------
checking for ocamlc.opt... /usr/bin/ocamlc.opt
checking for x86_64-pc-linux-gnu-ocamlc... /usr/bin/ocamlc.opt
checking for camlp4... /usr/bin/camlp4
Need build
********  Objective-Caml 3.10 is required  *********
*******  Check http://caml.inria.fr/  ********
Do you want this script to try to download and install ocaml
LOCALLY in mldonkey directory ?

still hangs there!
I have installed dev-lang/ocaml-3.11.1 and trying to emerge 
net-p2p/mldonkey-3.0.0
Comment 6 Jonathan-Christofer Demay 2009-09-22 15:56:17 UTC
mldonkey-3.0.0's configure script seems to check for ocaml-3.11.0 precisely, not for ocaml-3.11.*

This can be fixed by:
sed -i -e "s:3.11.0\*:3.11.\*:g" mldonkey-3.0.0/config/configure.in
Comment 7 Kamen Dokov 2009-09-22 16:20:11 UTC
(In reply to comment #6)
> mldonkey-3.0.0's configure script seems to check for ocaml-3.11.0 precisely,
> not for ocaml-3.11.*
> 
> This can be fixed by:
> sed -i -e "s:3.11.0\*:3.11.\*:g" mldonkey-3.0.0/config/configure.in
> 

Where in the ebuild should i insert this line ?
Comment 8 Martin von Gagern 2009-09-24 16:33:45 UTC
(In reply to comment #7)
> Where in the ebuild should i insert this line ?

It's not in the ebuild. You might use these commands until the ebuild gets fixed:
# ebuild /usr/portage/net-p2p/mldonkey/mldonkey-3.0.0.ebuild clean unpack
# sed -i 's/3\.11\.0/3.11/' \
/var/tmp/portage/net-p2p/mldonkey-3.0.0/work/mldonkey-3.0.0/config/configure.in
# ebuild /usr/portage/net-p2p/mldonkey/mldonkey-3.0.0.ebuild merge

Haven't tried whether the resulting app works, but at least it does compile.
Comment 9 Kamen Dokov 2009-09-25 16:38:25 UTC
I`m sorry i removed mldonkey,i`ll use amule for a while :)
Comment 10 Thomas Capricelli 2009-10-18 17:03:20 UTC
i'm hit by this bug today on stable amd64,

[ebuild  N    ] net-p2p/mldonkey-3.0.0  USE="fasttrack gd gnutella ocamlopt -doc -gtk -guionly -magic"


hangs with (in build.log):
.....
checking for ocamlc.opt... /usr/bin/ocamlc.opt
checking for x86_64-pc-linux-gnu-ocamlc... /usr/bin/ocamlc.opt
checking for camlp4... /usr/bin/camlp4
Need build
********  Objective-Caml 3.10 is required  *********
*******  Check http://caml.inria.fr/  ********
Do you want this script to try to download and install ocaml
LOCALLY in mldonkey directory ?

Comment 11 Thomas Capricelli 2009-10-18 17:15:46 UTC
The sed stuff works and i can emerge... can't/shouldn't this be done from the ebuild ? 
Comment 12 Jonathan-Christofer Demay 2009-10-25 16:31:38 UTC
This bug is almost one year old, and the fix is quite easy, can someone just put the damn sed into the ebuild !
Comment 13 Thomas Capricelli 2009-10-26 16:26:59 UTC
yes..... please.. There are so far only 'works for me' reports, aren't they ?
Comment 14 Aniruddha Shankar 2009-11-02 00:10:12 UTC
essentially, someone needs to diff the incorrect configure.in and correct configure.in and create a patch

once they do that, they need to insert a line into the ebuild with an epatch statement which will run the patch when the ebuild is run

if there's a document that outlines how I should try something of the sort, i can have a go at it
Comment 15 Jonathan-Christofer Demay 2009-11-02 20:43:54 UTC
Created attachment 209090 [details, diff]
net-p2p/mldonkey/files/mldonkey-3.0.0_ocaml-3.11.x.patch
Comment 16 Billy DeVincentis 2009-11-09 14:20:43 UTC
Created attachment 209734 [details]
mldonkey-3.0.0.ebuild

Created ebuild using patch. Seems to pass the hang point and is emerging for me right now.
Comment 17 Billy DeVincentis 2009-11-09 14:22:14 UTC
Created attachment 209736 [details]
Files for overlay
Comment 18 Denis Kaganovich 2009-12-07 13:43:10 UTC
Created attachment 212339 [details, diff]
mldonkey ebuild patch

IMHO better to change version for econf/configure to current (method copyed from configure), ebuild patch attached.
Comment 19 Martin von Gagern 2010-01-19 17:47:25 UTC
According to http://mldonkey.sourceforge.net/News mkdonkey-3.0.1 should fix this issue here as well. Bug #298982 has the bump request. We could make this one here depend on that one, if applying the fix in the ebuild is too much to ask.
Comment 20 spiralvoice 2010-05-22 20:04:26 UTC
This bug is fixed in MLDonkey 3.0.2
Comment 21 Raúl Porcel (RETIRED) gentoo-dev 2010-09-29 13:35:03 UTC
Use mldonkey-3.0.5