Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 247930 - net-analyzer/jnettop: fails with forced --as-needed
Summary: net-analyzer/jnettop: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Netmon project
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2008-11-21 12:16 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-06-02 11:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Build log (net-analyzer:jnettop-0.13.0-r1:20081121-080012.log,51.41 KB, text/plain)
2008-11-21 12:16 UTC, Diego Elio Pettenò (RETIRED) 		Details
Patch to fix library ordering and to respect user CFLAGS (jnettop-as-needed.patch,451 bytes, patch)
2009-02-13 04:51 UTC, Kevin Pyle 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-21 12:16:28 UTC 
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-21 12:16:59 UTC 
Created attachment 172672 [details]
Build log
Comment 2 Kevin Pyle 2009-02-13 04:51:27 UTC 
Created attachment 181832 [details, diff]
Patch to fix library ordering and to respect user CFLAGS

The upstream Makefile.am places libraries in AM_LDFLAGS, which is wrong.  They should be in jnettop_LDADD.

The upstream Makefile.am also overwrites CFLAGS, so user CFLAGS are not respected.  This patch removes that inappropriate assignment, since neither of the specified flags are worth retaining.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-02 11:54:22 UTC 
Thanks Kevin, patch applied now.