Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 247822 - media-sound/audtty: fails with forced --as-needed
Summary: media-sound/audtty: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Tony Vroon (RETIRED)
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2008-11-20 20:59 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-02-18 15:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (media-sound:audtty-0.1.9a:20081120-204456.log,18.62 KB, text/plain)
2008-11-20 20:59 UTC, Diego Elio Pettenò (RETIRED)
Details
Patch to modify files/audtty-0.1.9a-cc-and-destdir.patch for proper link ordering (audtty-patch.patch,534 bytes, patch)
2009-02-13 04:35 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-20 20:59:12 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-11-20 20:59:39 UTC
Created attachment 172559 [details]
Build log
Comment 2 Kevin Pyle 2009-02-13 04:35:27 UTC
Created attachment 181831 [details, diff]
Patch to modify files/audtty-0.1.9a-cc-and-destdir.patch for proper link ordering

The upstream Makefile places libraries before the object files, so --as-needed discarded the references.  Gentoo already patches the upstream Makefile to convert "cc" to "$(CC)".  That line needs an additional modification to put the libraries later on the line.  For simplicity, the attached patch modifies the existing Gentoo patch so that the libraries are reordered, in addition to the changes the Gentoo patch previously applied.  Thus, to fix the bug, use the attached patch to modify files/audtty-0.1.9a-cc-and-destdir.patch and commit the resulting patch file.
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2009-02-18 15:52:09 UTC
Your contribution to Gentoo Linux is highly appreciated :)

+*audtty-0.1.9a-r1 (18 Feb 2009)
+
+  18 Feb 2009; <chainsaw@gentoo.org>
+  files/audtty-0.1.9a-cc-and-destdir.patch, -audtty-0.1.9a.ebuild,
+  +audtty-0.1.9a-r1.ebuild:
+  Bump up audacious DEPEND to v1.5 where the D-Bus mess has been sorted out.
+  Patch by Kevin Pyle <kevin.pyle@bluecoat.com> fixes link ordering and
+  closes bug #247822 filed by Diego E. Flameeyes Pettenò
+  <flameeyes@gentoo.org>.