Attached is the ebuild, version bump for x11-wm/sawfish-1.3.4.ebuild. The ebuild is based on sawfish-1.3.3, the current one, and changes are: 1. No more snapshot. 2. Homepage update. 3. configure - 'enable/disable capplet' and 'disable-themer' removed, because they are ignored. 4. Rdepend: gtk+>=2.6.0, deleted pango 5. IUSE: deleted pango; now it's necessary. 6. patch: no more parallel make patch. Included in the package itself. (Libtool-patch remains. I don't know if it's necessary, but doesn't hurt anyway.) 7. doc files - NEWS deleted, because it doesn't exist - src/ChangeLog deleted, because obsolete. I've been using it for more than a month on amd64, so if it's legit, I'd claim that it's stable enough. :) Thanks in advance.
Created attachment 171696 [details] sawfish-1.3.4.ebuild
I don't think it's a good idea to add 1.3.4 until the problems reported on the mailing list are definitely resolved; it's not clear to me which do and don't apply to Gentoo. If there's anything in particular about it you would like to see added, I'm not opposed to patching 1.3.3 though.
Created attachment 171945 [details] sawfish-1.3.4.ebuild This one has slight fix in dodoc part: 1. NEWS is restored. I was wrong in the previous one by deleting it. 2. DOC is removed. It is not human readable, and used by sawfish.
Hi. I have looked into the ML archive, and found that the only problem relevant to Gentoo is that the themes don't appear in GUI. The pointer is at: http://sawfish.wikia.com/wiki/General_todos#Unsolved_issues_in_the_mailing_list Sorry that I don't know the criteria which version bump is worth, but it seems to me that this new one deserves to be, not only because of new features, but also of bugfixes. Thank you.
Created attachment 172926 [details] librep-0.17.2.ebuild dev-libs/librep-0.17.2.ebuild version bump.
Created attachment 172928 [details] rep-gtk-0.18.3.ebuild x11-libs/rep-gtk-0.18.3.ebuild version bump
Created attachment 172929 [details] sawfish-1.3.4.ebuild Now depends on >=librep-0.17.2 and >=rep-gtk-0.18.3
The newly submitted ebuild of sawfish depends on rep-gtk-0.18.3 and librep-0.17.2. With this new dependency, the last problem of sawfish-1.3.4, namely the disappearance of themes in GUI, is solved. librep-0.17.2.ebuild is based on librep-0.17-r2, and changes are: in src_unpack: - removed patches and sed; by the source update - added eautoreconf, because the src lacks config.sub rep-gtk-0.18.3.ebuild is based on rep-gtk-0.18-r3, and changes are: + slot="0"; previously, it was "gtk-2.0", but currently gtk-1.0 or 1.2 versions don't exist. + RDEPEND & DEPEND version update: librep, libglade, gtk+, libgnome*, pkgconfig + REDPEND: deleted libbonobo* + src_unpack: - removed all patches; by the source update - Is src_unpack not necessary any more? + src_compile: removed --with-gdk-pikbuf; no longer an option + doc: - added NEWS - added examples/ Now a message problem in rep-gtk; emerge warns about 'file collisions'. In fact, it's not a problem, because all the replaced files come from the previous installation of rep-gtk. Is this due to slot change? Thanks.
Created attachment 173726 [details] rep-gtk-0.18.3.ebuild Fixed 'file collision', by adding !<x11-libs/rep-gtk-0.18.
a package blocking an older version of itself is rarely if ever correct. There should either be no slotting if they aren't really parallel installable, or they should be in the same slot. The gtk-2.0 SLOT can be slotmove'd to be "0" if necessary via profiles/updates methods.
Created attachment 174054 [details] rep-gtk-0.18.3.ebuild Reverted the slot to the current one, which is used in rep-gtk-0.18-r3. No blocking is used. Sorry for my lack of experience. Thanks a lot.
sawfish-1.3.5 is out now
Oh nice. I didn't notice this before, but you removed the copyright notices. Well then it's simple: no, these ebuilds will absolutely not be used, and I will be making sure upstream gets rid of this as well.
Created attachment 176712 [details] patch for librep-0.17.2, to be applied against 0.17-r2 Uploaded patch, conserving the copyright part.
Created attachment 176714 [details] patch for rep-gtk-0.18.3.ebuild, to be applied against 0.18-r3 Patch to generate rep-gtk-0.18.3.ebuild.
Created attachment 176715 [details] patch to generate sawfish-1.3.5.1.ebuild, to be applied against 1.3.3 Because I didn't know what to do with copyright line, I submitted patches to generate the ebuilds for latest releases. (Is it OK for me to submit an ebuild which goes 'copyright...Gentoo Foundation'? I don't belong to that group.) Sorry for careless act.
Sorry for the strong reaction, but it's an important issue. You need to preserve the copyright notice because you modified an existing copyrighted ebuild. It would be fine for you to add a copyright notice for yourself if you made modifications (although such ebuilds would not be accepted by Gentoo, there would be no problem with you distributing them yourself), and it would be fine if you created an ebuild from scratch without a copyright notice (same comment applies, plus it would have to not even derive from things like skel.ebuild -- and I'm not sure about eclasses), but what you did was basically take an existing ebuild, strip out the copyright notice, and upload it. There's no problem with you uploading ebuilds with Gentoo copyright notices in it if they're based on existing files with Gentoo copyright notices (again, including skel.ebuild). But patches, as you have done now, are also not a problem, so thank you very much for these. (The usual disclaimer applies: I am not a lawyer. This is not legal advice.)
Change the summary name. The latest sawfish's ebuild patch is for 1.3.5.1.
I wrote: > Is it OK for me to submit an ebuild > which goes 'copyright...Gentoo Foundation'? I don't belong to that group.) The answer is here. See http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=3#doc_chap1_sect2 The submitted patches are OK according to it. Thank you all for reading.
sawfish 1.3.5.2 plus new versions of librep and rep-gtk are now in portage. Thank you for your help.
