Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 246621 - media-sound/lastfmplayer calls g++, cc directly
Summary: media-sound/lastfmplayer calls g++, cc directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2008-11-13 15:55 UTC by Steve Dibb (RETIRED)
Modified: 2009-05-11 18:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Dibb (RETIRED) gentoo-dev 2008-11-13 15:55:18 UTC
See the Makefiles for lastfmplayer, should use $(tc-getCXX) instead
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2009-04-08 12:51:04 UTC
Can you explain better what you mean? All I can see on makefiles is this

####### Compiler, tools and options

CC            = gcc
CXX           = g++

[snip]


.cpp.o:
        $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<"

.cc.o:
        $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<"


Everything looks good to me
Comment 2 Samuli Suominen gentoo-dev 2009-05-11 18:21:56 UTC
(In reply to comment #1)
> Can you explain better what you mean? All I can see on makefiles is this

Please get familiar with toolchain-funcs.eclass.

> 
> ####### Compiler, tools and options
> 
> CC            = gcc
> CXX           = g++
> 
> [snip]
> 
> 
> .cpp.o:
>         $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<"
> 
> .cc.o:
>         $(CXX) -c $(CXXFLAGS) $(INCPATH) -o "$@" "$<"
> 
> 
> Everything looks good to me
> 

It's wrong. It should be:

CC ?= gcc
CXX ?= g++

And after this it would pick the CC and CXX variables from environment, which we could pass by using toolchain-funcs.eclass, and tc-export CC CXX. Right now,
the way to fix this something like..

emake CC="$(tc-getCC)" CXX="$(tc-getCXX)"

Reason: This will surely break crosscompile/distcc/other special cases.
Comment 3 Samuli Suominen gentoo-dev 2009-05-11 18:34:55 UTC
In portage.