Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 239268 - app-mobilephone/smssend-3.4 homepage entry in ebuild is misinterpreted
Summary: app-mobilephone/smssend-3.4 homepage entry in ebuild is misinterpreted
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: [OLD] gpackages (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Gentoo Packages Website
URL: http://packages.gentoo.org/package/ap...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-01 18:03 UTC by Jaak Ristioja
Modified: 2014-01-08 08:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaak Ristioja 2008-10-01 18:03:19 UTC
app-mobilephone/smssend/smssend-3.4.ebuild has an invalid homepage entry, which is counted as 2 separate home pages (e.g. in packages.gentoo.org):

HOMEPAGE="None available" # was http://zekiller.skytech.org/smssend_menu_en.html
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2008-10-02 16:04:28 UTC
Actually that's quite valid - bash syntax and indeed ebuild syntax allows for comments at the ends of lines, including those that assign variables... The only limitation appears to be that it's a raw string that doesn't need variable expansion[1].

Let's see what infra has to say about this. (If this is the only ebuild that does this, we can still drop it in the package maintainer's lap - there's a case to be made that HOMEPAGE should be a valid URL.)

[1] http://devmanual.gentoo.org/ebuild-writing/variables/index.html:
  "Package's homepage. If you are unable to locate an official one, try to
   provide a link to freshmeat.net or a similar package tracking site. Never
   refer to a variable name in the string; include only raw text."
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-10-02 21:49:01 UTC
The ebuild should have zero or more valid URLs, separated with whitespace (Whitespace within a URL should be URL-escaped). That used to be documented somewhere, the maintainer needs to fix.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-10-02 21:50:33 UTC
From PMS:
\item[HOMEPAGE] The URI or URIs for a package's homepage, including protocols. May be defined by an eclass. See section~\ref{dependencies} for full syntax.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2008-10-03 02:33:20 UTC
Thanks, infra.
Comment 5 Alin Năstac (RETIRED) gentoo-dev 2008-10-05 09:17:26 UTC
I'm lost. What exactly you guys want me to do? As Jeroen said in comment 1, this is valid bash syntax.

For the record, I've commented the previous homepage in case it becomes alive again.
Comment 6 Alin Năstac (RETIRED) gentoo-dev 2008-10-05 10:23:14 UTC
What value do you want me to assign to HOMEPAGE when no such page is available?
repoman does not allow me to set it to empty string.

There are more packages that use "None available" as value for HOMEPAGE:
  app-mobilephone/smssend/smssend
  dev-libs/skyutils/skyutils
  net-libs/roadrunner/roadrunner

Comment 7 Jaak Ristioja 2009-08-09 10:51:50 UTC
(In reply to comment #6)
> What value do you want me to assign to HOMEPAGE when no such page is available?
> repoman does not allow me to set it to empty string.
> 
> There are more packages that use "None available" as value for HOMEPAGE:
>   app-mobilephone/smssend/smssend
>   dev-libs/skyutils/skyutils
>   net-libs/roadrunner/roadrunner
> 

I'm not a developer, but how about this:

HOMEPAGE="http://zekiller.skytech.org/smssend_menu_en.html http://www.barsnick.net/sw/smssend.html"
Comment 8 Alin Năstac (RETIRED) gentoo-dev 2009-08-15 08:54:43 UTC
We're supposed to remove dead homepages and the other homepage is 5 years old.

Anyway, the question remains. We should have a N/A value for HOMEPAGE and packages.g.o should correctly interpret such value.
Comment 9 Alec Warner (RETIRED) archtester gentoo-dev Security 2014-01-08 08:30:45 UTC
I'm happy with calling this a bug in the ebuild, it certainly is unlikely to be fixed in p.g.o.

-A