Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 236949 - dev-util/kbuild needs sys-apps/acl to compile
Summary: dev-util/kbuild needs sys-apps/acl to compile
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Markus Ullmann (RETIRED)
Depends on:
Reported: 2008-09-07 12:13 UTC by Jan Notka
Modified: 2008-12-03 20:23 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

fixes superfluous #include (kbuild_acl.patch,576 bytes, patch)
2008-09-07 13:46 UTC, Christian Authmann
Details | Diff
fixed Christian Authmann 's patch (kbuild-0.1.3-fix-acl-include.patch,575 bytes, text/plain)
2008-09-07 21:56 UTC, Alessio Cassibba (X-Drum)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Notka 2008-09-07 12:13:20 UTC
while building dev-util/kbuild it throws a message that sys/acl.h isn't available.
after merging sys-apps/acl it builds fine.

Reproducible: Always

Steps to Reproduce:
1. emerge kbuild

this package is needed by app-emulation/virtualbox-ose
Comment 1 Matthew Joiner 2008-09-07 13:44:09 UTC
(In reply to comment #0)
> while building dev-util/kbuild it throws a message that sys/acl.h isn't
> available.
> after merging sys-apps/acl it builds fine.
> Reproducible: Always
> Steps to Reproduce:
> 1. emerge kbuild
> this package is needed by app-emulation/virtualbox-ose

merging sys-apps/acl fixed this, thanks.
Comment 2 Christian Authmann 2008-09-07 13:46:27 UTC
Created attachment 164814 [details, diff]
fixes superfluous #include

same here.

/var/tmp/portage/dev-util/kbuild-0.1.3/work/kBuild-0.1.3/src/kmk/kmkbuiltin/mv.c:52:23: error: sys/acl.h: No such file or directory

Funny thing is: sys/acl.h isn't even used, just removing that include solves the problem as well.

acl functionality is only used in fastcopy(), which is only compiled when CROSS_DEVICE_MOVE is defined, but I couldn't find any reference to that macro outside of src/kmk/kmkbuiltin/mv.c, neither inside the project, inside system headers of even via google. It seems that this macro is never set, and thus the #include can be removed (or at least placed inside a #ifdef CROSS_DEVICE_MOVE section).

A patch doing the latter is attached.
Comment 3 David Watzke 2008-09-07 19:09:09 UTC
true that acl's not needed, I just created an empty /usr/include/sys/acl.h file and it built fine.
Comment 4 Alessio Cassibba (X-Drum) 2008-09-07 21:55:13 UTC
(In reply to comment #0)
Hi, thanks for you report can you please attach your:
emerge --info

(In reply to comment #3)
Thanks for your check and patch (btw it leaves an #endif without #if in line 54, i will post the corrected patch), as you said acl is only used in fastcopy(), so (imho) there is no problem with this approach.

Comment 5 Alessio Cassibba (X-Drum) 2008-09-07 21:56:49 UTC
Created attachment 164860 [details]
fixed Christian Authmann 's patch
Comment 6 Jan Notka 2008-09-07 22:08:37 UTC
> emerge --info
Portage (default-linux/amd64/2007.0, gcc-4.1.2, glibc-2.6.1-r0, 2.6.25-gentoo-r7 x86_64)
System uname: 2.6.25-gentoo-r7 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 4400+
Timestamp of tree: Sun, 07 Sep 2008 01:06:23 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.5.2-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.5
sys-devel/autoconf:  2.13, 2.61-r2
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
CFLAGS="-march=k8 -O2 -pipe -msse -msse2 -msse3 -ftracer -fweb -m3dnow"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=k8 -O2 -pipe -msse -msse2 -msse3 -ftracer -fweb -m3dnow"
FEATURES="candy ccache distlocks metadata-transfer parallel-fetch sandbox sfperms strict unmerge-orphans userfetch"
LINGUAS="de en"
MAKEOPTS="-j3 -s"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"

USE="3dnow 3dnowext 7zip S3TC X a52 aac aalib acpi additions alsa amarok amd64 amr amrnb amrwb ao arts async audiofile bash-completion bcp berkdb bidi big-tables bjam branding bzip2 cairo ccache cdr cdrom cg cli contrib cracklib cran crypt cscope curl cxx d dbus dga directfb divx dts dvd dvdnav dvdr dvdread eds effects enblend encode escreen etwin exif expat extraengine fam fbcon ffmpeg flac flash fortran gcj gd gdbm gecko gif glibc-omitfp glitz glsa glut gmedia gmp gpm gtk gtkhtml guile hal iconv icq icu idn imagemagick imlib inherit-graph inkjar java javascript jikes joystick jpeg jpeg2k junit kde kerberos kpathsea lame latex lcms libnotify libwww live lm_sensors logitech-mouse lua mad mailwrapper maps matroska mbrola midi mikmod mmx mmxext mng modplug moonlight motif mozbranding mozsvg mp2 mp3 mp4 mpeg2 mplayer msn mudflap musepack mysql ncurses network networking nfs nls nptl nptlonly nsplugin nspr ntp nvidia ocamlopt offensive ogg openal opengl openmp ophsmall oss pam pcre pdf perl plotutils plugins png prediction pulseaudio python qa qq qt3 qt3support qt4 quicktime radio rar readline recode reflection reiser4 reiserfs rtc ruby samba scanner sdl session sift silc slang smp solver soundtouch spell spl sqlite srt sse sse2 ssl startup-notification svg swat sysfs tcl tcltk tcpd themes theora threads tidy tiff tivo tk transcode truetype twolame unicode usb userlocales utempter v4l v4l2 vcd videos vim vistafree visualization vorbis wma wmp x264 xanim xcomposite xine xml xml2 xorg xpfast xpsmall xulrunner xv xvid xvmc zlib zoran zvbi" ALSA_CARDS="intel8x0" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="de en" USERLAND="GNU" VIDEO_CARDS="nv nvidia"
Comment 7 Markus Ullmann (RETIRED) gentoo-dev 2008-09-19 13:16:13 UTC
InCVS already (man I should really close these) ;)
Comment 8 Alessio Cassibba (X-Drum) 2008-12-03 20:23:58 UTC
I reported upstream the (fixed) Christian Authmann's patch:

(i'm replying on an already closed bug, sorry for this)