Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 236945 - layman-1.2.0 deletes existing directory when adding git overlay
Summary: layman-1.2.0 deletes existing directory when adding git overlay
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Gunnar Wrobel (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-07 11:39 UTC by tao
Modified: 2008-11-15 10:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tao 2008-09-07 11:39:11 UTC 
When adding git overlay and target directory already exist, layman exits with failure but it deletes this target directory. This behavior is different from eg. svn type overlays, where target directory is kept intact.

Reproducible: Always

Steps to Reproduce:
1. mkdir dir with git-overlay name (e.g. zen-overlay) in layman overlay dir and fill it with data
2. layman -L && layman -a zen-overlay

Actual Results:  
layman fails with:

* Running command "/usr/bin/git clone "git://zen-sources.org/zen/portage-overlay.git/" "/usr/portage/local/zen-overlay""...
fatal: destination directory '/usr/portage/local/zen-overlay' already exists.
* Failed to add overlay "zen-overlay".
* Error was: Adding the overlay failed!

and zen-overlay directory is removed completely.

Expected Results:  
layman aborting with failure message while keeping zen-overlay directory intact
Comment 1 Gunnar Wrobel (RETIRED) gentoo-dev 2008-11-15 10:34:08 UTC 
Fixed in layman-1.2.1. Available via portage.