Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 235539 - linux-mod.eclass: update-modules doesn't appear to be called
Summary: linux-mod.eclass: update-modules doesn't appear to be called
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
Depends on:
Reported: 2008-08-23 13:54 UTC by Richard Westwell
Modified: 2018-06-18 23:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

patch for linux-mod.eclass (linux-mod.eclass.patch,1.05 KB, patch)
2008-08-23 13:56 UTC, Richard Westwell
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Westwell 2008-08-23 13:54:52 UTC
I'm not sure but I think I might have spotted a bug within linux-mod.eclass
where update-modules is not getting called during the normal emerge process for a kernel module

first there's a check within linux-mod_pkg_preinst() to see if certain directories exist
i.e. [ -d "${D}etc/modules.d" ] && UPDATE_MODULES=true || UPDATE_MODULES=false
this is okay so far

next within linux-mod_pkg_postinst() the update_modules function is called
${UPDATE_MODULES} && update_modules;
still okay

However when we get to the update_modules function
it seems to be checking for the presence of files with content within the install destination directory
the command "grep -v -e "^#" -e "^$" ${D}/etc/modules.d/* >/dev/null 2>&1"
doesn't find anything as the ${D} image directory is now empty (within /var/tmp/portage), as we're now in post-install rather than pre-install 

attached is a suggested patch

Reproducible: Always

Steps to Reproduce:
1. emerge any kernel module ebuild that ues linux-mod and places files within /etc/modules.d/
Comment 1 Richard Westwell 2008-08-23 13:56:00 UTC
Created attachment 163621 [details, diff]
patch for linux-mod.eclass
Comment 2 Daniel Drake (RETIRED) gentoo-dev 2008-10-31 22:34:19 UTC
Patch looks good, thanks! Have you tested it?