Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 234003 - net-ftp/proftpd-1.3.1 ebuild encourages bad practices
Summary: net-ftp/proftpd-1.3.1 ebuild encourages bad practices
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Luca Longinotti (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-05 19:20 UTC by Allen Brooker (AllenJB)
Modified: 2009-02-17 22:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Brooker (AllenJB) 2008-08-05 19:20:15 UTC
The proftpd-1.3.1 ebuild contains the following:
	if use mysql && use postgres ; then
		ewarn "ProFTPD only supports either the MySQL or PostgreSQL modules."
		ewarn "Presently this ebuild defaults to mysql. If you would like to"
		ewarn "change the default behaviour, merge ProFTPD with:"
		ewarn "USE='-mysql postgres' emerge proftpd"
		epause 5
	fi

To my knowledge, using USE on the commandline is considered bad practice (because it's not remembered). In my opinion the last line of the ewarn message should be changed to something like:
echo 'net-ftp/proftpd -mysql postgres' >> /etc/portage/package.use
emerge -avN proftpd
Comment 1 Joakim 2008-10-10 16:49:34 UTC
Actually, what's "bad" is the restriction. From proftpd module doc:
"In 1.3.0rc1, the mod_sql module gained the ability to be compiled with multiple backend modules supported, e.g. to have both mod_sql_mysql and mod_sql_postgres usable in the same proftpd daemon."

so it's actually ok to compile for both servers and you then set specific to each container which backend to use.
Comment 2 Bernard Cafarelli gentoo-dev 2009-02-17 22:10:49 UTC
Fixed in 1.3.2-r1 (which does allow both backends), thanks for the report