Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 231673 - java-utils-2.eclass: Patch for adding tools.jar to the classpath
Summary: java-utils-2.eclass: Patch for adding tools.jar to the classpath
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 250923
  Show dependency tree
 
Reported: 2008-07-13 11:02 UTC by James Le Cuirot
Modified: 2009-05-03 11:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
eant-needs-tools.patch (patch,941 bytes, patch)
2008-07-13 11:03 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2008-07-13 11:02:31 UTC
Betelgeuse said he would prefer an EANT_NEEDS_TOOLS variable over a jdk-tools virtual so here's a patch for java-utils-2.eclass. Please add this soon so I can delete the virtual from the overlay.
Comment 1 James Le Cuirot gentoo-dev 2008-07-13 11:03:19 UTC
Created attachment 160252 [details, diff]
eant-needs-tools.patch
Comment 2 Jory A. Pratt gentoo-dev 2008-12-21 04:20:41 UTC
Is anyone looking at this anymore. I would like to see netbeans with support for ruby as many other users would also. This is a crucial step to moving gentoo forward to be used in a business enviroment.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2008-12-21 21:01:12 UTC
(In reply to comment #2)
> Is anyone looking at this anymore. I would like to see netbeans with support
> for ruby as many other users would also. This is a crucial step to moving
> gentoo forward to be used in a business enviroment.
> 

In contrast to what the comment in the Netbeans ebuild says tools.jar is actually always put to ant classpath. You can see this by reading /usr/bin/ant. We have been discussing this issue every once in a while and have we don't think we should add support for tools.jar in general. tools.jar is a collection of separate things so we should instead have things like a virtual for javadoc. Then it can be provided also by packages like dev-java/gjdoc.
Comment 4 Miroslav Šulc gentoo-dev 2008-12-22 10:41:14 UTC
The last time I tried that, tools.jar was not on classpath when running eant from ebuild. This applies to both netbeans and my attempt to bump jax-ws to version 2.1 (needed to resolve another netbeans bug). tools.jar is available on classpath in case ant is run from command line, iirc, but that's useless for packaging packages that need tools.jar. And if it would be true that "tools.jar is actually always put to ant classpath", there would be no need for this bug nor bug #174182 imo. So the first sentence in comment #3 is not clear to me. If I understand it correctly, I should not get "package not found" error for tools.jar packages while compiling netbeans or jax-ws as "tools.jar is actually always put to ant classpath". Or does that mean that tools.jar is available to ant but not available for the compiled application?

Anyway, I need a vorking solution to be able to compile both ruby support in netbeans and jax-ws 2.1.
Comment 5 Petteri Räty (RETIRED) gentoo-dev 2008-12-22 20:17:14 UTC
(In reply to comment #4)
> Or does that mean that tools.jar is available to
> ant but not available for the compiled application?
> 

Maybe you need to take the Java quiz again :). Ant classpath != javac classpath. Remember that we always use -Dbuild.sysclasspath=ignore nowadays.
Comment 6 Miroslav Šulc gentoo-dev 2008-12-22 23:54:35 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Or does that mean that tools.jar is available to
> > ant but not available for the compiled application?
> > 
> 
> Maybe you need to take the Java quiz again :). Ant classpath != javac
> classpath. Remember that we always use -Dbuild.sysclasspath=ignore nowadays.
> 

Maybe I should :-) Thank you for clarification, now I recall I saw -Dbuild.sysclasspath=ignore somewhere before :-P

So to say it correctly, netbeans needs tools.jar on javac classpath to compile ruby cluster, and the same is needed for jaxw-ws 2.1 to compile.
Comment 7 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2008-12-29 00:27:25 UTC
There ya go crybabies, patch added. Remebemer it's just an intermediate solution for build-time dep only, virtuals mentioned in bug #174182 is the right way. But I figured that usage of this variable would be easier to detect and convert later so enjoy. Also realize that you never had to wait for this, you could have always write own src_compile() and call java-config --tools there. Like jedit did. Oh well.