Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226845 - x11-misc/lavaps: patch (lavaps-2.7-this-makes-it-compile.patch) changes both autotools source and result
Summary: x11-misc/lavaps: patch (lavaps-2.7-this-makes-it-compile.patch) changes both ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: bad-autotools
  Show dependency tree
 
Reported: 2008-06-14 17:45 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2008-06-29 13:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-14 17:45:21 UTC
The patch in summary is touching both Makefile.in and Makefile.am, probably to avoid autotools rebuild.

This treatment is usually reserved for a few selected system packages that cannot have their autotool scripts rebuilt.

This _could_ cause maintainermode-driven rebuild (see http://blog.flameeyes.eu/articles/2008/06/13/maintaner-mode ), which is something we should be avoiding as much as possible.

Please just patch Makefile.am and/or configure.in/.ac and rebuild autotools, unless you have very good reasons not to.
Comment 1 Peter Alfredsen (RETIRED) gentoo-dev 2008-06-29 13:19:28 UTC
   29 Jun 2008; Peter Alfredsen <loki_val@gentoo.org>
+  files/lavaps-2.7-build-fixes.patch,
+  files/lavaps-2.7-this-makes-it-compile.patch, lavaps-2.7-r2.ebuild:
+  Build-only fixes to avoid makefile patching, acinclude patching, and
+  sundry other ways people have abused this package over the years. Fixes
+  bug #226845.
+