Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226239 - media-libs/gd: builds tests with FEATURES=-test
Summary: media-libs/gd: builds tests with FEATURES=-test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
: 226289 (view as bug list)
Depends on:
Blocks: test-n-example-build
  Show dependency tree
 
Reported: 2008-06-13 11:14 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2011-12-15 16:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
media-libs/gd-2.0.35-r2 update (gd-2.0.35-r1-to-2.0.35-r2.diff,874 bytes, patch)
2010-04-10 16:13 UTC, Didier Barvaux 		Details | Diff
patch for configure.ac and Makefile.am (gd-2.0.35-cond-tests.patch,1.32 KB, patch)
2010-04-10 16:14 UTC, Didier Barvaux 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-13 11:14:59 UTC 
The package seems to be building tests during "make all" phase even though I don't have FEATURES=test enabled. For details see my blog: http://blog.flameeyes.eu/articles/2008/06/11/please-dont-build-your-examples-by-default .

It would be nice if the tests were disabled by default and only built with FEATURES=test. You can find an example patch usually suitable for upstream on the blog above.

Thanks,
Diego
Comment 1 Didier Barvaux 2010-04-10 16:12:16 UTC 
Hi all,

Here are two patches that fix the problem:
 - A patch for configure.ac and Makefile.am to add a new --enable-test option
   and use the result of the option to build or not build tests.
 - An update to media-libs/gd-2.0.35-r2 to apply the previous patch, run
   eautoreconf and use the new configure option.

Tested on x86 with and without test feature.

The patch on configure.ac and Makefile.am was not proposed upstream yet. I wait for feedback from Gentoo devs first.

Didier
Comment 2 Didier Barvaux 2010-04-10 16:13:10 UTC 
Created attachment 227269 [details, diff]
media-libs/gd-2.0.35-r2 update
Comment 3 Didier Barvaux 2010-04-10 16:14:11 UTC 
Created attachment 227271 [details, diff]
patch for configure.ac and Makefile.am
Comment 4 Didier Barvaux 2010-11-13 14:38:38 UTC 
7 months without any progress on this bug! Is the patch I proposed a bad one? Any feedback on it would be welcome...
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2010-11-13 14:43:09 UTC 
Why not just replace "noinst_PROGRAMS" with "check_PROGRAMS" in Makefile.am? 
That way they'll only build when 'make check' is called.
Comment 6 Didier Barvaux 2010-11-13 14:47:26 UTC 
(In reply to comment #5)
> Why not just replace "noinst_PROGRAMS" with "check_PROGRAMS" in Makefile.am? 
> That way they'll only build when 'make check' is called.

The tests that are built are as far as I know not automated tests, so I didn't think about the check target. Is it fine to use the check target to build binaries without running any test with them?
Comment 7 SpanKY gentoo-dev 2011-12-15 16:36:24 UTC 
*** Bug 226289 has been marked as a duplicate of this bug. ***
Comment 8 SpanKY gentoo-dev 2011-12-15 16:38:15 UTC 
seems like it was fixed by this commit:

http://sources.gentoo.org/media-libs/gd/gd-2.0.35-r3.ebuild?r1=1.1&r2=1.2