Bug 220797 – x11-apps/xinit-1.0.8-r3 overwrites /etc/env.d/90xsession

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Chris Smith 2008-05-07 18:15:59 UTC]

xinit-1.0.8-r3 overwrites /etc/env.d/90xsession with an example file even after it was properly edited and setup according to the openrc migration instructions

Reproducible: Always

[Comment 1 Doug Goldstein (RETIRED) 2008-05-07 18:24:47 UTC]

xinit != baselayout

While I did add this there, I'm now thinking it should just be documented and not provided.

[Comment 2 Chris Smith 2008-05-07 19:30:50 UTC]

(In reply to comment #1)
> xinit != baselayout

I thought as much...but as it was tightly related to the baselayout/openrc upgrade...

Probably OK to provide it as long as it doesn't overwrite an already configured file with no warning.

[Comment 3 Andreas Klauer 2008-06-08 09:12:24 UTC]

The reason that xinit overwrites /etc/env.d/90xsession with every merge / update is that /etc/make.globals puts /etc/env.d/ into the CONFIG_PROTECT_MASK variable, which results in /etc/env.d/ not being protected at all.

/etc/env.d/90xsession has either to be moved back to some protected file like /etc/conf.d/xdm or rc, or /etc/env.d/ has to be taken out of the CONFIG_PROTECT_MASK default setting in make.globals.

Otherwise the default behaviour will be that Gentoo kills custom settings with every emerge.

Actually I think the best solution would be to not include a 90xsession file with xinit at all, but instead tell the user to create one such file himself. The user has to edit the file anyway as the default sets nothing, and this way it would be a user created file that'd not ever get overwritten by emerge.

[Comment 4 Martin Mokrejš 2009-01-23 11:26:04 UTC]

Still an issue with x11-apps/xinit-1.0.8-r3. Does anybody care? Luckily, things magically work for people even with the default contents (everything commented out) - like me.

[Comment 5 Martin Mokrejš 2009-01-23 11:28:23 UTC]

See also bug #229769.

[Comment 6 Donnie Berkholz (RETIRED) 2009-01-23 22:39:49 UTC]

Yeah, I care. That's why this xinit still isn't stable. I wish we had a better solution than just telling people to create it themselves, but I can't really think of one, so I'll probably end up doing that.

[Comment 7 Martin Mokrejš 2009-01-29 16:59:00 UTC]

Why don't you go for /etc/conf.d/xdm or /etc/conf.d/xsession then?

[Comment 8 Donnie Berkholz (RETIRED) 2009-01-30 04:02:11 UTC]

Because it's not used by xdm specifically (it's startx), and it's not a service so doesn't belong in conf.d (an explicit parallel to init.d).

[Comment 9 Martin Mokrejš 2009-01-30 18:15:17 UTC]

A search for startx bugs in freedesktop.org bugzilla lead me to some interesting cases:

https://bugs.freedesktop.org/show_bug.cgi?id=9583
https://bugs.freedesktop.org/show_bug.cgi?id=13462

[Comment 10 Donnie Berkholz (RETIRED) 2009-02-10 02:49:13 UTC]

+*xinit-1.0.8-r4 (10 Feb 2009)
+
+  10 Feb 2009; Donnie Berkholz <[e-mail]>;
+  +xinit-1.0.8-r4.ebuild:
+  (#220797) Instead of letting settings in /etc/env.d/90xsession get
+  overwritten on every update, don't install anything there and just tell
+  people what to do.
+