building app-emulation/xen (all versions) fails with gcc-4.3.0
make -f /var/tmp/portage/app-emulation/xen-3.2.0/work/xen-3.2.0/xen/Rules.mk include/xen/compile.h
make: Entering directory `/var/tmp/portage/app-emulation/xen-3.2.0/work/xen-3.2.0/xen'
sed: -e expression #6, char 945: unterminated `s' command
make: *** [include/xen/compile.h] Error 1
emerging xen works fine with gcc-4.2.3
Steps to Reproduce:
Created attachment 149315 [details]
Patch fixing sed command in xen/Makefile
This patch escapes two "-characters.
Created attachment 149317 [details]
Ebuild for patch above
I think this bug is caused by the output of "gcc -v":
For Version 4.2.3 it contains:
--with-pkgversion=Gentoo 4.2.3 p1.0
for Version 4.3.0 it contains:
--with-pkgversion='Gentoo 4.3.0 p1.0'
The single quotes of the second output mess up a sed command in line #173 of xen/Makefile.
The patch works as well for XEN 3.2.1. I wonder why this is not in portage jet?
@Bert: Have you already reported the issue upstream?
Created attachment 157221 [details]
Ebuild for Xen 3.2.1 (see patch above)
Allow xen 3.2.1 to be compiled with gcc 4.3.x
Pls add the 198121 dependency tree.
*** Bug 221269 has been marked as a duplicate of this bug. ***
*** Bug 235531 has been marked as a duplicate of this bug. ***
Created attachment 163863 [details, diff]
Quoting issues are only a symptom, not the cause of the problem. If you fix them, you still end up with a messed up "compiler" information in the Xen boot screen.
I will include the attached patch that uses --version instead of -v for GCC eyecandy.
+*xen-3.3.0 (01 Sep 2008)
+ 01 Sep 2008; Robert Buchholz <email@example.com> +files/xen-sed-gcc.patch,
+ metadata.xml, -xen-3.2.0.ebuild, xen-3.2.1.ebuild, +xen-3.3.0.ebuild:
+ Version bump to Xen 3.3 (bug #201792).
+ Bugs fixed:
+ * Fix invalid sed that broke gcc-4.3 (bug #217151)