Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 214168 - dev-util/git: users demand a perl-free Git
Summary: dev-util/git: users demand a perl-free Git
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Sylvain BERTRAND
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-21 21:11 UTC by Robin Johnson
Modified: 2008-03-24 11:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
git-1.5.4.4 ebuild patch (attachment.cgi,382 bytes, patch)
2008-03-22 13:45 UTC, Sylvain BERTRAND
Details | Diff
20080322-git-1.5.5.4-noperl.patch (20080322-git-1.5.5.4-noperl.patch,10.80 KB, patch)
2008-03-22 23:48 UTC, Robin Johnson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-03-21 21:11:30 UTC
sylvain: Ok, here's the deal then, since you want a perl-free Git.

Produce a patch for the upstream Git makefile, implementing 'NO_PERL', in the same vein as 'NO_TCLTK'. Should disable building of the scripts I've mentioned, plus gitweb.

I'll test it on a box with no Perl binary installed. It needs to pass the Git tests (FEATURES=test emerge dev-util/git) as well as me installing it and try the basic Git stuff on my git clone of the kernel.
Comment 1 Sylvain BERTRAND 2008-03-22 13:45:31 UTC
Created attachment 146888 [details, diff]
git-1.5.4.4 ebuild patch

I'll do it when I'm confortable on nvidia driver developement (if it's not done upstream before). In the meantime you can apply the ebuild patch (2 lines) that will spare USE="-perl" systems to pull down tons of perl dependencies.
Comment 2 Ingmar Vanhassel (RETIRED) gentoo-dev 2008-03-22 14:13:46 UTC
(In reply to comment #1)
> In the meantime you can apply the ebuild patch (2 lines) that
> will spare USE="-perl" systems to pull down tons of perl dependencies.

That patch is bogus, you don't just pretend that git doesn't depend on these perl packages.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2008-03-22 14:58:34 UTC
Comment on attachment 146888 [details, diff]
git-1.5.4.4 ebuild patch

You've already been told 3 times that that patch is not acceptable, please stop attaching it over and over again.
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-03-22 23:48:46 UTC
Created attachment 146960 [details, diff]
20080322-git-1.5.5.4-noperl.patch

The attached patch does 95% of the work of making Perl optional.

The following testcases need to have their git-remote usage written out.
t5502-quickfetch.sh
t5512-ls-remote.sh
t5520-pull.sh

Additionally, configure.ac and the Makefile need work to get configure --without-perl to work properly.

Usage:
# patch <....
# gmake NO_PERL=NoThanks
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-03-24 00:08:27 UTC
This IS in the tree now - however Slyvain, when you've got some time for yourself, I expect you to take the patch to upstream, and either have them rewrite the noted testcases, or do so yourself.
Comment 6 Sylvain BERTRAND 2008-03-24 11:13:03 UTC
[ANNOUNCE] GIT 1.5.5-rc1
...
 * "git checkout" is rewritten in C.
 * "git remote" is rewritten in C.
...

Seems I'm not alone to think like that. Now, it only needs additional autoconf magic from your gmake patch.