Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 214142 - media-libs/aalib-1.4_rc5 handles partial drawing in aarender() wrongly
Summary: media-libs/aalib-1.4_rc5 handles partial drawing in aarender() wrongly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-21 13:39 UTC by Reimar Döffinger
Modified: 2012-02-11 14:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix the described behaviour (ignoring X offset of render window) (renderxoffset.diff,447 bytes, patch)
2008-03-21 13:41 UTC, Reimar Döffinger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Reimar Döffinger 2008-03-21 13:39:50 UTC
This bug can be seen very clearly with e.g.
mplayer -vo aa -monitoraspect 3
in which case a big part of the picture is missing or there is even completely black output.
The reason for this is, when drawing only a part of the picture via aarender() the first X coordinate is used for the loop count, but it is not applied to the destination and source image index, thus instead of (re)drawing the middle part of the image, it draws always the left part.

Reproducible: Always

Steps to Reproduce:
1. run mplayer -vo aa -monitoraspect 3

Actual Results:  
only the left part of the image is draw (depending on the video, only the left black bar might be draw, so you will see nothing at all - if so use a slightly smaller value for -monitoraspect).

Expected Results:  
All of the image should be drawn, and -monitoraspect should only squeeze the image, not cause part of it to miss.

I will attach a patch shortly.
I report this here, since upstream seems to be dead :-(
Comment 1 Reimar Döffinger 2008-03-21 13:41:21 UTC
Created attachment 146765 [details, diff]
fix the described behaviour (ignoring X offset of render window)
Comment 2 Łukasz Damentko (RETIRED) gentoo-dev 2008-10-30 16:55:37 UTC
Reassinging to maintainer-needed since eradicator has left Gentoo.
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2012-02-11 14:06:34 UTC
Pushed patch as-is:

>*aalib-1.4_rc5-r4 (11 Feb 2012)
>
>  11 Feb 2012; Sergei Trofimovich <slyfox@gentoo.org> +aalib-1.4_rc5-r4.ebuild,
>  +files/aalib-1.4_rc5-fix-aarender.patch, -aalib-1.4_rc5-r3.ebuild:
>  Fix bug #214142 in aarender() reported and fixed by Reimar Döffinger. The
>  patch also fixes resizing of 'mplayer -vo aa' for me.

Thanks for the fix, Reimar!