Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 213328 - revdep-rebuild prepends '=' to slotted atoms (app-portage/gentoolkit)
Summary: revdep-rebuild prepends '=' to slotted atoms (app-portage/gentoolkit)
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 170220
  Show dependency tree
 
Reported: 2008-03-14 00:20 UTC by michael@smith-li.com
Modified: 2008-04-24 02:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
revdep-rebuild_r479if-ordered-use-equals.patch (revdep-rebuild_r479if-ordered-use-equals.patch,1.21 KB, patch)
2008-03-14 00:28 UTC, michael@smith-li.com
Details | Diff
revdep-rebuild_r479if-ordered-use-equals.patch (revdep-rebuild_r479if-ordered-use-equals.patch,1.22 KB, patch)
2008-03-14 00:33 UTC, michael@smith-li.com
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description michael@smith-li.com 2008-03-14 00:20:48 UTC
This was fixed at revision 473, but the fix is incomplete because it doesn't account for when the user tells r-r to skip package ordering.

If the package list is ordered by portage the atoms will have versions, so the '=' is appropriate.

If ordering is skipped the list of packages will be unversioned slotted atoms, and the '=' should not be prepended. Patch forthcoming.
Comment 1 michael@smith-li.com 2008-03-14 00:28:52 UTC
Created attachment 146071 [details, diff]
revdep-rebuild_r479if-ordered-use-equals.patch

If the .5_order tempfile is found we can assume packages are versioned, not slotted, and prepend '='.

If .5_order is not found, we use .4_ebuilds, which will either have the '=' in itself, or will have slotted atoms that don't require the '='.
Comment 2 michael@smith-li.com 2008-03-14 00:33:09 UTC
Created attachment 146073 [details, diff]
revdep-rebuild_r479if-ordered-use-equals.patch

blah, cruft, sorry
Comment 3 Paul Varner (RETIRED) gentoo-dev 2008-03-14 03:22:23 UTC
$ svn commit -m "Fix prepending '=' to slotted atoms (Bug #213328)"
Sending        revdep-rebuild/revdep-rebuild
Transmitting file data .
Committed revision 481.
Comment 4 Paul Varner (RETIRED) gentoo-dev 2008-04-24 02:32:54 UTC
Released in gentoolkit-0.2.4_rc4