Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 212696 - OpenRC-0.1 released, ebuilds attached.
Summary: OpenRC-0.1 released, ebuilds attached.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on: 213988 openrc-upgrade-path
Blocks: 214957
  Show dependency tree
 
Reported: 2008-03-08 11:32 UTC by Roy Marples
Modified: 2008-03-27 14:54 UTC (History)
44 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openrc-0.1.ebuild (openrc-0.1.ebuild,4.08 KB, text/plain)
2008-03-08 11:33 UTC, Roy Marples
Details
baselayout-2.0.0.ebuild (baselayout-2.0.0.ebuild,3.95 KB, text/plain)
2008-03-08 11:33 UTC, Roy Marples
Details
openrc-0.1.ebuild (openrc-0.1.ebuild,4.07 KB, text/plain)
2008-03-10 11:13 UTC, Benedikt Böhm (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Marples 2008-03-08 11:32:38 UTC
I'm not going to host the baselayout tarball forever - I suggest that the current svn repo is trimmed to match it and is maintained there.

I'm also not going to request keywords or stable keywords - that's entirely up to you guys now.

Thanks!
Comment 1 Roy Marples 2008-03-08 11:33:06 UTC
Created attachment 145541 [details]
openrc-0.1.ebuild
Comment 2 Roy Marples 2008-03-08 11:33:30 UTC
Created attachment 145542 [details]
baselayout-2.0.0.ebuild
Comment 3 Duncan 2008-03-08 12:48:08 UTC
Where do (upstream, I think) bugs go, now?  Others will probably want to know too, so having the pointer here should be a good thing.
Comment 4 Roy Marples 2008-03-08 12:50:55 UTC
(In reply to comment #3)
> Where do (upstream, I think) bugs go, now?  Others will probably want to know
> too, so having the pointer here should be a good thing.

http://bugs.marples.name/enter_bug.cgi?product=OpenRC

True, I'll not be actively looking for bugs after it's in portage, but I'm also
happy to be CC'ed here.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2008-03-08 22:33:25 UTC
(In reply to comment #1)
> Created an attachment (id=145541) [edit]
> openrc-0.1.ebuild

On a side note, this has a broken inherit w/ [[ "${PV}" = "9999" ]], you are overriding all the previous inherit lines there.

Comment 6 Benedikt Böhm (RETIRED) gentoo-dev 2008-03-10 11:13:49 UTC
Created attachment 145719 [details]
openrc-0.1.ebuild

updated ebuild with sane inherit and fixed MAKE_ARG vs. MAKE_ARGS
Comment 7 Roy Marples 2008-03-10 12:36:06 UTC
Is this allowed?

if [ "${PV}" = "9999" ]; then
   GIT=git
else
   GIT=
fi
inherit foo ${GIT}

I've updated my git ebuild like so and it seems to work. I've also sucked in Hollows fix - thanks.
Comment 8 Petteri Räty (RETIRED) gentoo-dev 2008-03-10 18:50:03 UTC
(In reply to comment #7)
> Is this allowed?
> 
> if [ "${PV}" = "9999" ]; then
>    GIT=git
> else
>    GIT=
> fi
> inherit foo ${GIT}
> 

It is.
Comment 9 Petteri Räty (RETIRED) gentoo-dev 2008-03-10 18:50:48 UTC
(In reply to comment #8)
> 
> It is.
> 

Just remove the useless else.
Comment 10 Roy Marples 2008-03-10 19:51:28 UTC
(In reply to comment #9)
> Just remove the useless else.

So package managers clean the working environment then?
Comment 11 Petteri Räty (RETIRED) gentoo-dev 2008-03-10 21:32:31 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > Just remove the useless else.
> 
> So package managers clean the working environment then?
> 

What do you mean? The conditional inherit trick is in devmanual:
http://devmanual.gentoo.org/general-concepts/portage-cache/index.html
Comment 12 Sven 2008-03-11 00:53:08 UTC
> What do you mean? The conditional inherit trick is in devmanual:
> http://devmanual.gentoo.org/general-concepts/portage-cache/index.html

Look at comment #7. Roy has used a variable GIT which should be cleared prior to the if or inside the else-case. Otherwise, it could be undefined in certain situations.
Comment 13 Doug Goldstein (RETIRED) gentoo-dev 2008-03-20 05:02:56 UTC
Just so the bug is aware, I've been taking this up to get it in the tree on behalf of base-system. It will hit the tree next week most likely since I will be out of town this coming weekend. Also I need to finish coordinating with everyone.
Comment 14 SpanKY gentoo-dev 2008-03-22 23:05:43 UTC
Comment on attachment 145541 [details]
openrc-0.1.ebuild

comment #5 is wrong, the code Roy has is correct wrt inherit
Comment 15 Jakub Moc (RETIRED) gentoo-dev 2008-03-22 23:08:33 UTC
(In reply to comment #14)
> (From update of attachment 145541 [details] [edit])
> comment #5 is wrong, the code Roy has is correct wrt inherit

Well, if it's correct, then someone should fix portage to stop spitting warnings about it. Or more likely you didn't see them since you didn't emerge the 9999 version.

Comment 16 Doug Goldstein (RETIRED) gentoo-dev 2008-03-27 14:54:16 UTC
openrc-0.2 and baselayout-2.0.0 have hit the tree and are ready for use and consumption.