Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 210415 - media-sound/audacity ebuild should depend on jack-audio-connection-kit
Summary: media-sound/audacity ebuild should depend on jack-audio-connection-kit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
: 211183 211212 (view as bug list)
Depends on: 209494
Blocks:
  Show dependency tree
 
Reported: 2008-02-16 23:17 UTC by jovie1024
Modified: 2008-03-06 17:46 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
audacity-1.3.4-jack-automagic.patch (audacity-1.3.4-jack-automagic.patch,975 bytes, patch)
2008-02-24 08:30 UTC, Jakub Moc (RETIRED)
Details | Diff
audacity-1.3.4-r1.ebuild.diff (audacity-1.3.4-r1.ebuild.diff,1.23 KB, patch)
2008-02-24 08:33 UTC, Jakub Moc (RETIRED)
Details | Diff
audacity-1.3.4-r1.ebuild.diff (audacity-1.3.4-r1.ebuild.diff,1.46 KB, patch)
2008-02-24 08:36 UTC, Jakub Moc (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jovie1024 2008-02-16 23:17:51 UTC
The audacity ebuild should include a reference to the jack-audio-connection-kit, either via a USE flag or in RDEPENDS.

Audacity 1.3.4-r1 compiles fine with the lowest version of Jack available on my AMD64 machine (version 0.103.0), but my machine had an older version of Jack installed (it was still at an 0.9x version).  Since it wasn't included in the audacity deps, it caused audacity compilation to fail.  It's an easy feature to add, but isn't obvious to the user why the emerge fails without investigating the output of ./configure; I wasn't aware that Audacity depended on Jack until looking through the ./configure and make output.

Reproducible: Always

Steps to Reproduce:
1. Have an old version of jack-audio-connection-kit installed (pre-0.103.0)
2. Emerge audacity
3. Audacity fails to install
Comment 1 Alexis Ballier gentoo-dev 2008-02-17 19:32:06 UTC
dep added, thanks
Comment 2 Andrés Cordero 2008-02-17 21:40:14 UTC
Why has the dependency been added without a USE flag?
I've had Audacity working fine without jack installed, and now my system wants to pull it in.
Comment 3 Alexis Ballier gentoo-dev 2008-02-17 22:00:37 UTC
(In reply to comment #2)
> Why has the dependency been added without a USE flag?
> I've had Audacity working fine without jack installed, and now my system wants
> to pull it in.
> 

because upstream provides no reliable way to disable it ? and then it would result in different binaries even if built with the exact same options whether jack was installed at build time or not. And that wouldnt solve the initial problem if adding only an useflag: USE=-jack and have an old jack installed and that'll fail...
Comment 4 Tristan Heaven (RETIRED) gentoo-dev 2008-02-18 13:47:07 UTC
So add a configure option? That dependency doesn't solve the initial problem either.
Comment 5 Alexis Ballier gentoo-dev 2008-02-18 14:30:59 UTC
(In reply to comment #4)
> So add a configure option? 

patches sent upstream too are very welcome

> That dependency doesn't solve the initial problem
> either.

why that ?

Comment 6 RonnyPeine 2008-02-18 20:26:52 UTC
Wouldn't it be possible to just print a message at pkg_unpack stage and/or detect if the installed jackd is in an incompatible version and die? It's completely anoying to install bloat like jackd just for audacity, i'm not needing it at all, it's waste of resources and maintenance time.
Comment 7 Matt 2008-02-19 16:23:34 UTC
(In reply to comment #1)
> dep added, thanks
> 

Why?  I have never had jack on my systems over the years and have zero intention of installing it just to use audacity.  Things were 100% fine until this "update".  Now I can't simply "emerge world" because jack will be installed, in-turn mess up other sound apps by seeing some kind of jack installed, and I now can't use --depclean anymore since the jack dependency makes it fail.  
If the jack use flag is there, then a system is going to have a full jack install for all the other apps needing it, right (I'm asking an honest question)?  
Could the possibility exist that the OP's world file is messed up and portage isn't seeing it installed and thus not updating it?  Perhaps he/she installed it with a --oneshot or (if it's REALLY old) --inject?

(I'm asking honest questions, I'm not trying to flame anyone of come off as "pissed-off".  I'm only pretty annoyed that I have to sit in front of my machines babysitting them every single time I want to update my machine to make sure that jack isn't installed / continuing a portage fail because of it)  
Comment 8 Marcus Furlong 2008-02-19 21:42:30 UTC
(In reply to comment #7)
> Why?  I have never had jack on my systems over the years and have zero
> intention of installing it just to use audacity.  Things were 100% fine until
> this "update".  Now I can't simply "emerge world" because jack will be
> installed, in-turn mess up other sound apps by seeing some kind of jack
> installed, and I now can't use --depclean anymore since the jack dependency
> makes it fail.  

I agree with this as well, I never needed jack to run audacity, so don't think it should be a dependency now.

The audacity wiki also states that audacity using jack has not been extensively tested and has a number of issues:

   http://www.audacityteam.org/wiki/index.php?title=Linux_Issues#JACK

It also mentions that audacity-with-jack should be enabled by using portaudio with both jack and alsa enabled. How about adding jack and alsa USE keywords to portaudio (and requiring portaudio to use the minimum version of jack that audacity requires)? Then audacity could use a portaudio USE keyword to enable jack support?

(As it is, "emerge world" is trying to pull in jack, but audacity is even going to get rebuilt to use the new jack headers..)
Comment 9 Dave Favis-Mortlock 2008-02-23 13:42:04 UTC
(In reply to comment #2)
> Why has the dependency been added without a USE flag?
> I've had Audacity working fine without jack installed, and now my system wants
> to pull it in.
> 

I agree, a USE flag for jack-audio-connection-kit is needed. Why should I have Jack forced upon me when Audacity works perfectly well without it?
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2008-02-23 17:31:33 UTC
*** Bug 211183 has been marked as a duplicate of this bug. ***
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2008-02-23 22:28:47 UTC
*** Bug 211212 has been marked as a duplicate of this bug. ***
Comment 12 Jakub Moc (RETIRED) gentoo-dev 2008-02-24 08:30:31 UTC
Created attachment 144482 [details, diff]
audacity-1.3.4-jack-automagic.patch

Patch to fix automagic jack-audio-connection-kit dependency.
Comment 13 Jakub Moc (RETIRED) gentoo-dev 2008-02-24 08:33:43 UTC
Created attachment 144483 [details, diff]
audacity-1.3.4-r1.ebuild.diff

Fixed ebuild...
Comment 14 Jakub Moc (RETIRED) gentoo-dev 2008-02-24 08:34:02 UTC
Reopen this bug, rest the above patch please.
Comment 15 Jakub Moc (RETIRED) gentoo-dev 2008-02-24 08:36:13 UTC
Created attachment 144485 [details, diff]
audacity-1.3.4-r1.ebuild.diff

Errr, we'd better run eautoreconf as well... ;)
Comment 16 Jakub Moc (RETIRED) gentoo-dev 2008-02-24 09:04:03 UTC
Ugh, this thing just sucks... Same fix needed in 

lib-src/portaudio-v19/configure.in
lib-src/portaudio-v19/bindings/cpp/build/gnu/configure.ac

plus WTH does this bundle its own portaudio (also see Bug 209494).
Comment 17 Jakub Moc (RETIRED) gentoo-dev 2008-02-24 10:01:05 UTC
And more... 

- automagic dependency on media-libs/alsa-lib
- instead of using media-libs/allegro this links a static bundled copy in, great :S
- this supports wxGTK-2.8 but we are forcing 2.6, why?
Comment 18 Matt 2008-02-29 18:51:34 UTC
Thank you for working on this Jakub.  

Do you have the power to make these edits the the live ebuild?  I just set myself up an overlay making jack optional so I can make portage shut up so I can actually emerge world again (and use depclean).

Anyway, thank you for your work!

M.
Comment 19 Alexis Ballier gentoo-dev 2008-03-01 16:59:10 UTC
should be fixed in -r2
Comment 20 Matt 2008-03-01 18:28:30 UTC
(In reply to comment #19)
> should be fixed in -r2
> 

Fantastic!  Thank you!

(P.S. I didn't mean to make it seem I was stepping your toes.  I was only asking Jakub a question, not try and go over your head.  I HOPE you understand that)
Comment 21 Alexis Ballier gentoo-dev 2008-03-01 19:48:36 UTC
(In reply to comment #20)

> (P.S. I didn't mean to make it seem I was stepping your toes.  I was only
> asking Jakub a question, not try and go over your head.  I HOPE you understand
> that)

Heh no problem I didn't see it like that ;)
I was just completely busy with non gentoo stuff for a few weeks; now I'm emptying the backlog :)
Comment 22 Leonid Evdokimov 2008-03-06 17:30:12 UTC
In `diff audacity-1.3.4-{r1,r2}.ebuild` I see following hunk:

@@ -74,7 +89,8 @@
 		$(use_with twolame libtwolame) \
 		$(use_with soundtouch) \
 		$(use_with libsamplerate) \
-		|| die
+		$(use_with alsa) \
+		$(use_with jack)
 
 	emake || die
 }

Was not it a typo to remove `die` on econf failure from -r2 ?
Comment 23 Leonid Evdokimov 2008-03-06 17:38:16 UTC
(In reply to comment #22)

> Was not it a typo to remove `die` on econf failure from -r2 ?

Excuse me for flood, I've found out it was not.

econf() from /usr/lib/portage/bin/ebuild.sh `die's itself it something goes wrong.
Comment 24 Matt 2008-03-06 17:46:35 UTC
(In reply to comment #19)
> should be fixed in -r2
> 

Just thought I'd mention that -r2 works fine here.  x86-32, no jack.

Again, thanx for the update!