Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 208591 - perl-module eclass should stop exporting useless functions
Summary: perl-module eclass should stop exporting useless functions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: perl-eclass
  Show dependency tree
 
Reported: 2008-02-02 15:58 UTC by Jakub Moc (RETIRED)
Modified: 2009-03-06 12:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2008-02-02 15:58:08 UTC
<snip>
EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst pkg_prerm pkg_postrm src_compile src_install src_test src_unpack

...

perl-module_pkg_setup() {

        perlinfo
}


perl-module_pkg_preinst() {

        perlinfo
}
</snip>

Well, this is seriously annoying since it overrides useful exported functions from other eclasses by unneeded, dummy stuff if you don't realize how much stuff is actually exported. This is fatal with webapps e.g. if you get the inherit order wrong. 

Please remove this from EXPORT_FUNCTIONS at least. Also, copying perlinfo to perl-app eclass and letting people inherit that instead, since the variables are the only thing they are after would be nice.
Comment 1 Torsten Veller (RETIRED) gentoo-dev 2009-03-06 12:01:01 UTC
For EAPI=2 perl-module.eclass doesn't export pkg_* functions anymore.