Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 207954 - net-wireless/ipw3945-1.2.2-r1: compile fixes for 2.6.24
Summary: net-wireless/ipw3945-1.2.2-r1: compile fixes for 2.6.24
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords: STABLEREQ
: 207999 (view as bug list)
Depends on:
Blocks: kernel-2.6.24 213283
  Show dependency tree
 
Reported: 2008-01-28 19:50 UTC by Jiri Pittner
Modified: 2008-03-15 17:01 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Pittner 2008-01-28 19:50:04 UTC
after kernel update to 2.6.24-gentoo,
emerge ipw3945 crashes with:
  CC [M]  /var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.o
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c: In function 'ipw_start_association':
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:4444: error: implicit declaration of function 'MAC_ARG'
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:4444: warning: too few arguments for format
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c: In function 'ipw_net_set_mac_address':
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:15217: warning: too few arguments for format
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c: In function 'ipw_pci_probe':
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:16594: error: implicit declaration of function 'SET_MODULE_OWNER'
make[2]: *** [/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.o] Error 1


Reproducible: Always

Steps to Reproduce:
1.install new kernel, compile it, reboot, update /usr/src/linux
2.energe ipw3945 version 1.2.2
3.

Actual Results:  
make[1]: Entering directory `/usr/src/linux-2.6.24-gentoo'
  CC [M]  /var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.o
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c: In function 'ipw_start_association':
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:4444: error: implicit declaration of function 'MAC_ARG'
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:4444: warning: too few arguments for format
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c: In function 'ipw_net_set_mac_address':
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:15217: warning: too few arguments for format
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c: In function 'ipw_pci_probe':
/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.c:16594: error: implicit declaration of function 'SET_MODULE_OWNER'
make[2]: *** [/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2/ipw3945.o] Error 1
make[1]: *** [_module_/var/tmp/portage/net-wireless/ipw3945-1.2.2/work/ipw3945-1.2.2] Error 2


Expected Results:  
installed driver

emerge --info
Portage 2.1.3.19 (default-linux/x86/2007.0/desktop, gcc-4.1.2, glibc-2.6.1-r0, 2.6.24-gentoo i686)
=================================================================
System uname: 2.6.24-gentoo i686 Genuine Intel(R) CPU T2500 @ 2.00GHz
Timestamp of tree: Mon, 28 Jan 2008 09:16:01 +0000
app-shells/bash:     3.2_p17-r1
dev-java/java-config: 1.3.7, 2.1.3
dev-lang/python:     2.4.4-r8, 2.5.1-r5
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.10-r5
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.16.1-r3, 2.17-r1, 2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.24
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4m -msse2 -pipe -fno-omit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -march=pentium4m -msse2 -pipe -fno-omit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer parallel-fetch sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.sh.cvut.cz/MIRRORS/gentoo ftp://mirror.switch.ch/mirror/gentoo/ http://gentoo.supp.name/ "
LANG="C"
LINGUAS="sk cs de nl"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/gnuradio /usr/portage/local/layman/erazor /usr/local/portage /usr/local/overlays/erazor-zone.de"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X Xaw3d a52 aac aalib ac3 acl acpi alsa amr arts berkdb bitmap-fonts blas bluetooth bonobo bzip2 cairo cddb cdparanoia cdr cli cracklib crypt dbus dri dv dvb dvd dvdnav dvdr dvdread eds emboss encode esd evo exif fam ffmpeg firefox fortran ftp gcj gd gdbm gif gnome gphoto2 gpm gps gstreamer gtk hal http hwac3 icc iconv ieee1394 imagemagick imap ipv6 isdnlog jabber java javascript jpeg jpeg2k kde kerberos lapack ldap lesstif libwww lirc lm_sensors lprng mad mbox midi mikmod mime mmap mmx mozilla mp3 mpeg mpi mudflap mysql nas ncurses nls nptl nptlonly nsplugin obex ogg opengl openmp oss paste64 pcmcia pcre pdf perl plotutils png posix pppd python qt3 qt3support qt4 quicktime readline real reflection samba scanner sdl session sharedmem smartcard sndfile sockets socks5 sox spell spl sse sse2 ssl svg svga tcl tcltk tcpd tetex threads tiff tk truetype truetype-fonts type1-fonts unicode usb usrp v4l v4l2 vanilla vcd vorbis wifi win32codecs wxwindows x86 xine xml xorg xpm xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="sk cs de nl" USERLAND="GNU" VIDEO_CARDS="radeon fglrx vesa"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2008-01-28 19:53:28 UTC
And what's exactly wrong with in-kernel iwlwifi drivers?
Comment 2 Jan Kundrát (RETIRED) gentoo-dev 2008-01-28 20:12:59 UTC
Please try the patch from upstream bug tracker [1]. Also note that Intel developer said "We will have iwlwifi driver in 2.6.24 kernel. So ipw3945 is not necessary to work with 2.6.24."

[1] http://bughost.org/bugzilla/show_bug.cgi?id=1547
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2008-01-29 08:05:17 UTC
*** Bug 207999 has been marked as a duplicate of this bug. ***
Comment 4 Taiyang Chen 2008-01-31 04:58:22 UTC
Please try the in-kernel iwlwifi driver (iwl3945)
Emerge iwl3945-ucode afterwards should get you going :)
I have been using it for a few days now and it seems good enough to replace the old ipw3945.
Comment 5 Luís Costa 2008-02-10 12:29:58 UTC
the new iwlwifi driver does not provide me with any new functionality, as far as I can see, and there are still some nasty bugs, that make my card not work, or worse, freezes the system.However, ipw with the upstream patch works like a charm :)
Comment 6 Pacho Ramos gentoo-dev 2008-02-10 13:13:48 UTC
(In reply to comment #4)
> Please try the in-kernel iwlwifi driver (iwl3945)
> Emerge iwl3945-ucode afterwards should get you going :)
> I have been using it for a few days now and it seems good enough to replace the
> old ipw3945.
> 

I tried some months ago iwlwifi and it was a mess. I am now trying it again and also have some problems. I will try to test it and report all problems I find, but I would prefer get ipw3945 working also with kernel-2.6.24

Thanks
Comment 7 Jim Ramsay (lack) (RETIRED) gentoo-dev 2008-02-11 16:22:07 UTC
Okay, I have added net-wireless/ipw3945-1.2.2-r1 with this upstream patch.

Unfortunately, I'm not presently set up to ensure that this ebuild works, so I have p.masked it.  Please unmask it yourself and report back here if this actually works for you.  After 1 or 2 positive reports I'll be unmasking this for everyone.

I may get to testing it myself in the next couple days too.
Comment 8 dt 2008-02-13 08:49:33 UTC
(In reply to comment #7)
> Okay, I have added net-wireless/ipw3945-1.2.2-r1 with this upstream patch.
> 
> Unfortunately, I'm not presently set up to ensure that this ebuild works, so I
> have p.masked it.  Please unmask it yourself and report back here if this
> actually works for you.  After 1 or 2 positive reports I'll be unmasking this
> for everyone.
> 
> I may get to testing it myself in the next couple days too.

Trying iwlwifi from the new kernel ended poorly.  Everything seemed to work fine but trying to associate to an AP would fail (no errors given).  The problem was that it was stuck on 802.11a and trying to `iwconfig wlan0 modu 11g` would give me "Operation not supported" or similar.

So I tried your patched ipw3945 and everything works great again.  Thank you!
Comment 9 Jan Kundrát (RETIRED) gentoo-dev 2008-02-13 09:01:28 UTC
(In reply to comment #8)
> Trying iwlwifi from the new kernel ended poorly.

Please make sure you open a bugreport at http://bughost.org/bugzilla/ if there already isn't one.
Comment 10 Jan Kundrát (RETIRED) gentoo-dev 2008-02-13 09:21:42 UTC
(In reply to comment #7)
> Okay, I have added net-wireless/ipw3945-1.2.2-r1 with this upstream patch.

Works fine here on 2.6.23-gentoo-r1.

And I guess you want to ask users to report bugs in iwlwifi to http://bughost.org/bugzilla/, not to us.
Comment 11 Jim Ramsay (lack) (RETIRED) gentoo-dev 2008-02-13 14:53:13 UTC
(In reply to comment #10)
> Works fine here on 2.6.23-gentoo-r1.

Good enough for me, I'm unmasking.

> And I guess you want to ask users to report bugs in iwlwifi to
> http://bughost.org/bugzilla/, not to us.

Er, yes.  Thanks :)
Comment 12 Daniel Drake (RETIRED) gentoo-dev 2008-02-13 16:11:33 UTC
reopening as this is not fixed in stable tree
Comment 13 Jan Kundrát (RETIRED) gentoo-dev 2008-02-14 13:45:49 UTC
Dear arch teams, please mark net-wireless/ipw3945-1.2.2-r1 stable. The only change we have made is a patch taken from upstream's bugreport (not approved by Intel) that fixes compilation on 2.6.24 and newer.
Comment 14 Jan Kundrát (RETIRED) gentoo-dev 2008-02-14 13:46:47 UTC
Dear arch teams, please mark net-wireless/ipw3945-1.2.2-r1 stable. The only change we have made is a patch taken from upstream's bugreport (not approved by Intel) that fixes compilation on 2.6.24 and newer.

(now for real :])
 

Comment 15 Joshua Jackson (RETIRED) gentoo-dev 2008-02-17 20:29:52 UTC
x86 stable
Comment 16 Santiago M. Mola (RETIRED) gentoo-dev 2008-03-15 17:01:53 UTC
amd64 stable, closing.