Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 207937 - kde-base/kdesdk-3 - depend on valgrind using a USE flag, not an ARCH flag
Summary: kde-base/kdesdk-3 - depend on valgrind using a USE flag, not an ARCH flag
Status: RESOLVED DUPLICATE of bug 158066
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 209443
  Show dependency tree
 
Reported: 2008-01-28 17:29 UTC by Jeroen Roovers (RETIRED)
Modified: 2008-02-18 22:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
=kdesdk-207937-valgrind-removal.patch (kdesdk-207937-valgrind-removal.patch,3.16 KB, patch)
2008-02-11 16:58 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2008-01-28 17:29:36 UTC
gentoo/cvs/gentoo-x86/kde-base/kdesdk $ grep valgrind kdesdk-*
kdesdk-3.5.5.ebuild:DEPEND="x86? ( >=dev-util/valgrind-3.2.0 )
kdesdk-3.5.6.ebuild:DEPEND="x86? ( >=dev-util/valgrind-3.2.0 )
kdesdk-3.5.6-r1.ebuild:DEPEND="!alpha? ( !sparc? ( !ia64? ( >=dev-util/valgrind-3.2.0 ) ) )
kdesdk-3.5.7.ebuild:DEPEND="!alpha? ( !sparc? ( !ia64? ( >=dev-util/valgrind-3.2.0 ) ) )
kdesdk-3.5.8.ebuild:DEPEND="!alpha? ( !sparc? ( !ia64? ( >=dev-util/valgrind-3.2.0 ) ) )

1) Rather than adding arch after arch that valgrind has no use for, it would be better to simply add a USE=valgrind, use.mask that generally and reenable it specifically for x86.

2) If that's too much trouble, then maybe it's better to not pull in valgrind at all, in exactly the same way that kdesdk-4 doesn't, and maybe add an einfo to the effect that installing valgrind might help using kdesdk. I suggest this because the ebuilds and eclasses in no way use valgrind, which in turn suggests that the build system automagically depends on valgrind or that valgrind is merely a runtime dependency and should be in RDEPEND, not DEPEND.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2008-01-28 18:16:54 UTC
This is basically a dupe of Bug 158066 for kde-base/kcachegrind; I reopened it now. I don't get this either.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-02-11 16:58:39 UTC
Created attachment 143219 [details, diff]
=kdesdk-207937-valgrind-removal.patch
Comment 3 Bo Ørsted Andresen (RETIRED) gentoo-dev 2008-02-18 22:39:59 UTC
Thanks. The dependency is going away. It isn't needed at all at run or build time.

*** This bug has been marked as a duplicate of bug 158066 ***