Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 207536 - net-misc/cisco-vpnclient-3des patch for 2.6.24 kernel
Summary: net-misc/cisco-vpnclient-3des patch for 2.6.24 kernel
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Chris Gianelloni (RETIRED)
URL: http://www.tuxx-home.at/
Whiteboard:
Keywords:
: 208797 (view as bug list)
Depends on:
Blocks: kernel-2.6.24
  Show dependency tree
 
Reported: 2008-01-26 11:14 UTC by Antti Mäkelä
Modified: 2008-03-01 00:12 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output of failed patch (2.6.24.patch-7005.out,4.88 KB, text/plain)
2008-02-02 19:49 UTC, Devin Heckman
Details
cisco-vpnclient-3des-4.8.01.0640.ebuild (cisco-vpnclient-3des-4.8.01.0640.ebuild,2.08 KB, text/plain)
2008-02-03 08:47 UTC, Antti Mäkelä
Details
Corrected patch for 4.8.00.0490 (2.6.24_4.8.00.0490.patch,4.09 KB, patch)
2008-02-03 22:24 UTC, David Klempner
Details | Diff
patch for 2.6.24 with makefile EXTRA_CFLAGS change for amd64 (2.6.24_4.8.00.0490-amd64.patch,4.54 KB, patch)
2008-02-04 03:48 UTC, Horace Ip
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Mäkelä 2008-01-26 11:14:35 UTC
Apparently 2.6.24 kernel requires yet another patch for Cisco-vpn-3des, available at http://projects.tuxx-home.at/ciscovpn/patches/vpnclient-linux-2.6.24-final.diff - please update the ebuild.
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2008-02-02 14:15:20 UTC
OK, this is in the tree now.

Thanks for the patch!
Comment 2 Devin Heckman 2008-02-02 19:46:22 UTC
The patch doesn't apply cleanly, which is what I thought would happen (happened when I tested it locally). Someone will need to hack at this some more.
Comment 3 Devin Heckman 2008-02-02 19:49:48 UTC
Created attachment 142533 [details]
output of failed patch
Comment 4 Antti Mäkelä 2008-02-02 22:16:35 UTC
Ah - I should have probably mentioned that the patch is for 4.8.01, not for 4.8.00..
Comment 5 Tobias Muehlenbruch 2008-02-03 01:00:03 UTC
When i emerged net-misc/cisco-vpnclient-3des-4.8.00.0490-r1, the emerge process failed. (probably related to comment #4)
I posted the error message below. The Version cisco-vpnclient-3des-4.8.00.0490 emerges nicely without any problems.

Please fix this bug.


The error message:
# emerge net-misc/cisco-vpnclient-3des

>>> Emerging (2 of 2) net-misc/cisco-vpnclient-3des-4.8.00.0490-r1 to /
 * vpnclient-linux-x86_64-4.8.00.0490-k9.tar.gz RMD160 SHA1 SHA256 size ;-) ...       [ ok ]
 * checking ebuild checksums ;-) ...                                      [ ok ]
 * checking auxfile checksums ;-) ...                                     [ ok ]
 * checking miscfile checksums ;-) ...                                    [ ok ]
 * checking vpnclient-linux-x86_64-4.8.00.0490-k9.tar.gz ;-) ...          [ ok ]
 * Determining the location of the kernel source code
 * Found kernel source directory:
 *     /usr/src/linux
 * Found kernel object directory:
 *     /lib/modules/2.6.23-gentoo-r3/build
 * Found sources for kernel version:
 *     2.6.23-gentoo-r3
>>> Unpacking source...
>>> Unpacking vpnclient-linux-x86_64-4.8.00.0490-k9.tar.gz to /var/tmp/portage/net-misc/cisco-vpnclient-3des-4.8.00.0490-r1/work
 * Applying 2.6.22.patch ...                                              [ ok ]
 * Applying 2.6.24.patch ...

 * Failed Patch: 2.6.24.patch !
 *  ( /usr/portage/net-misc/cisco-vpnclient-3des/files/2.6.24.patch )
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/net-misc/cisco-vpnclient-3des-4.8.00.0490-r1/temp/2.6.24.patch-28844.out

 *
 * ERROR: net-misc/cisco-vpnclient-3des-4.8.00.0490-r1 failed.
 * Call stack:
 *                                    ebuild.sh, line 1701:  Called dyn_unpack
 *                                    ebuild.sh, line  817:  Called qa_call 'src_unpack'
 *                                    ebuild.sh, line   44:  Called src_unpack
 *   cisco-vpnclient-3des-4.8.00.0490-r1.ebuild, line   40:  Called epatch '/usr/portage/net-misc/cisco-vpnclient-3des/files/2.6.24.patch'
 *                                eutils.eclass, line  303:  Called die
 * The specific snippet of code:
 *                              die "Failed Patch: ${patchname}!"
 *  The die message:
 *   Failed Patch: 2.6.24.patch!
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/net-misc/cisco-vpnclient-3des-4.8.00.0490-r1/temp/build.log'.
 
Comment 6 Joseph D. Wieber, Jr. 2008-02-03 03:37:25 UTC
I have the same issue as posted by Tobias Muehlenbruch. Is there a solution for this error yet?
Comment 7 Antti Mäkelä 2008-02-03 08:46:44 UTC
(In reply to comment #6)
> I have the same issue as posted by Tobias Muehlenbruch. Is there a solution for
> this error yet?

Solution is basically use 4.8.01 instead of 4.8.00 and remove the 2.6.22 patch (it's already in 4.8.01). 

Here's an updated ebuild for 4.8.01. Use filename

cisco-vpnclient-3des-4.8.01.0640.ebuild
Comment 8 Antti Mäkelä 2008-02-03 08:47:41 UTC
Created attachment 142578 [details]
cisco-vpnclient-3des-4.8.01.0640.ebuild

cisco-vpnclient-3des-4.8.01.0640.ebuild is identical to cisco-vpnclient-3des-4.8.00.0490-r1.ebuild except the kernelpatch for 2.6.22 is removed.
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2008-02-03 22:04:13 UTC
*** Bug 208797 has been marked as a duplicate of this bug. ***
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2008-02-03 22:05:01 UTC
Reopen, this is broken and doesn't apply.
Comment 11 David Klempner 2008-02-03 22:24:01 UTC
Created attachment 142614 [details, diff]
Corrected patch for 4.8.00.0490

I just hacked the 2.6.24 patch to apply properly to 4.8.00.0490 after applying the 2.6.22 patch.

NB: It builds for me with no extra warnings on both 2.6.23-gentoo-r3 and 2.6.24-gentoo, but I did not try actually loading it on either!

I also fixed a bug in the patch for sub-2.6.24-- it unilaterally changed the return type of interceptor_init to void from int, instead of just changing it for >= 2.6.24.
Comment 12 Devin Heckman 2008-02-03 22:36:31 UTC
patch in comment #11 seems to fix all problems and works on a 2.6.24 kernel.
Comment 13 Horace Ip 2008-02-04 03:48:30 UTC
Created attachment 142628 [details, diff]
patch for 2.6.24 with makefile EXTRA_CFLAGS change for amd64

I have attached a patch that modifies the makefile for amd64 CFLAGS->EXTRA_CFLAGS, else the module will not compile
Comment 14 James Ausmus 2008-02-04 08:19:23 UTC
(In reply to comment #13)
> Created an attachment (id=142628) [edit]
> patch for 2.6.24 with makefile EXTRA_CFLAGS change for amd64
> 
> I have attached a patch that modifies the makefile for amd64
> CFLAGS->EXTRA_CFLAGS, else the module will not compile
> 

This patch seems to have done the trick for me - successfully started service and connected to a VPN.
Comment 15 Jesse Adelman 2008-02-04 20:54:24 UTC
Howdy. I've got kernel 2.6.22, but the 2.6.24 patch failure stops me from installing this. Should I comment out the patch in the ebuild for <2.6.24 kernels? Thanks.
Comment 16 Chris Gianelloni (RETIRED) gentoo-dev 2008-02-05 02:04:52 UTC
Ehh... I tested the stupid thing against 4.8.01... I'll fix this tonight... sorry about that...
Comment 17 Daniel Drake (RETIRED) gentoo-dev 2008-02-13 15:58:16 UTC
Reopening as above comments suggest this isn't fixed
Comment 18 Chris Gianelloni (RETIRED) gentoo-dev 2008-02-29 01:11:00 UTC
Wait... I thought that I had fixed this.  Is this fixed or not?
Comment 19 David Klempner 2008-02-29 03:55:07 UTC
Comment #17 was mistaken; it's fine.
Comment 20 Chris Gianelloni (RETIRED) gentoo-dev 2008-03-01 00:12:41 UTC
OK... thanks...