Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 206525 - arm sysv.S patch has incompatible @progbits (should be %progbits)
Summary: arm sysv.S patch has incompatible @progbits (should be %progbits)
Status: VERIFIED DUPLICATE of bug 167356
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: ARM Linux
: High major (vote)
Assignee: Gentoo Toolchain Maintainers
URL: http://archives.gentoo.org/gentoo-emb...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-18 13:45 UTC by Christopher Friedt
Modified: 2008-01-20 12:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
obseletes gcc-4.1.2-patches-1.0.2.tar.bz2/patch/62_all_gcc4-noteGNUstack.patch (62_all_gcc4-noteGNUstack.patch,5.44 KB, patch)
2008-01-18 13:48 UTC, Christopher Friedt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Friedt 2008-01-18 13:45:00 UTC
exactly the same problem found here:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=422971

and I've traced it to

gcc-4.1.2-patches-1.0.2.tar.bz2/patch/62_all_gcc4-noteGNUstack.patch


Incorrect:
===================================================================
--- libffi/src/arm/sysv.S.jj	2004-10-28 15:10:11.000000000 +0200
+++ libffi/src/arm/sysv.S	2005-02-08 16:14:02.282767581 +0100
@@ -207,3 +207,6 @@ LSYM(Lepilogue):
  .ffi_call_SYSV_end:
          .size 
CNAME(ffi_call_SYSV),.ffi_call_SYSV_end-CNAME(ffi_call_SYSV)

+#if defined __ELF__ && defined __linux__
+	.section	.note.GNU-stack,"",@progbits
+#endif
===================================================================
Correct:
===================================================================
--- libffi/src/arm/sysv.S.jj	2004-10-28 15:10:11.000000000 +0200
+++ libffi/src/arm/sysv.S	2005-02-08 16:14:02.282767581 +0100
@@ -207,3 +207,6 @@ LSYM(Lepilogue):
  .ffi_call_SYSV_end:
          .size 
CNAME(ffi_call_SYSV),.ffi_call_SYSV_end-CNAME(ffi_call_SYSV)

+#if defined __ELF__ && defined __linux__
+	.section	.note.GNU-stack,"",%progbits
+#endif
===================================================================

Reproducible: Always

Actual Results:  
as fails for sysv.S

Expected Results:  
as successful for sysv.S

Apparently ARM asm does not allow the use of '@' as a variable indicator, only '%'. '@' indicates a comment. Thus, with the current patchset, it's impossible to create a cross-compiler for arm-softfloat-linux-gnu with gcc-4.1.2. 

I'll also include a replacement for the patch file in question.
Comment 1 Christopher Friedt 2008-01-18 13:48:46 UTC
Created attachment 141222 [details, diff]
obseletes gcc-4.1.2-patches-1.0.2.tar.bz2/patch/62_all_gcc4-noteGNUstack.patch

see line 148
Comment 2 SpanKY gentoo-dev 2008-01-20 03:37:49 UTC
looks like i fixed it already, just didnt post the new patchset

i'll roll it now

*** This bug has been marked as a duplicate of bug 167356 ***
Comment 3 Christopher Friedt 2008-01-20 12:23:25 UTC
Thanks !