Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199850 - Support for libffi in toolchain.eclass
Summary: Support for libffi in toolchain.eclass
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Toolchain Maintainers
Depends on:
Blocks: 160183 163724 198875 200679 209673 209675
  Show dependency tree
Reported: 2007-11-21 00:12 UTC by David Leverton
Modified: 2008-09-29 01:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

patch (libffi.patch,1.73 KB, patch)
2007-11-21 00:16 UTC, David Leverton
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Leverton 2007-11-21 00:12:10 UTC
Attached patch adds libffi USE-flag to gcc ebuilds, so it can be built independently of gcj.  This should allow the removal of the horrible and broken dev-libs/libffi.
Comment 1 David Leverton 2007-11-21 00:16:47 UTC
Created attachment 136562 [details, diff]

Tested with gcc 3.4.6-r2 and 4.1.2 on amd64.

The toolchain folks know the eclass far better than me, so they may want to change things a bit if there's anything done inappropriately, but the important parts are the sed and the change to the ffitarget.h move to make it happen with the new USE-flag.

This will cause the build of most gcc 3.4.x versions to fail if the objc USE-flag is set, because those ebuilds try to make the same change again.  I'm not sure what the best solution for that is, so I didn't try to do anything in the patch, but if the objc-implies-libffi logic is considered desirable, it probably should be moved into the eclass as well.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2008-02-11 16:26:14 UTC
*** Bug 209675 has been marked as a duplicate of this bug. ***
Comment 3 SpanKY gentoo-dev 2008-02-16 22:28:01 UTC
ive added it ... the libtool cruft will have to wait for a general solution
Comment 4 Bo Ørsted Andresen 2008-09-08 17:06:10 UTC
# cat toolchain.eclass
is_libffi() {
        has libffi ${USE} || return 1
        use libffi

Comment 5 SpanKY gentoo-dev 2008-09-29 01:48:23 UTC
thanks, ive fixed that now