The current Portage implementation of use() is: use() { useq ${1} } I don't see any need for useq any more so we should just remove it in EAPI 2.
i dont see the point in breaking backwards compatibility since there's no overhead and no maintenance cost
(In reply to comment #1) > i dont see the point in breaking backwards compatibility since there's no > overhead and no maintenance cost > Well removing it would send a clear signal that it should not be used.
and what's wrong with using it ?
See also bug 262813 which is related. (In reply to comment #1) > i dont see the point in breaking backwards compatibility since there's no > overhead and no maintenance cost I would also say that there's no (at least no urgent) need to remove the useq and hasq commands from package managers.
There's a repoman check for useq and hasq in git now: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=de32b0d92ee28965c137bea637cddf6d8c0679c2
Also, portage will generate a QA Notice if hasq or useq is called: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=039439c2cc1546701cbb7403ea387581f08d5be0
(In reply to comment #5) > There's a repoman check for useq and hasq in git now: (In reply to comment #6) > Also, portage will generate a QA Notice if hasq or useq is called: This should be sufficient to prevent useq and hasq from being used. Closing.
I've disabled the QA Notice for pkg_prerm and pkg_postrm, since it's annoying to see these warnings due to /var/db/pkg/*/*/environment.bz2 containing long since removed hasq and useq calls: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=6620e74643e0baf040488557b1fff7273654a44d
Let's consider finally removing the command in a future EAPI.
A solution that everyone agreed upon is in place. Introducing EAPI dependent treatment of these functions will be more maintenance cost than leaving things as they are. Therefore closing.
*** Bug 654546 has been marked as a duplicate of this bug. ***
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=c2f413d6a1b820854681847870f94ff08ac35c2a commit c2f413d6a1b820854681847870f94ff08ac35c2a Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2020-10-18 09:32:26 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2020-10-18 09:32:26 +0000 Revert "Skip QA Notice for hasq/useq during *rm phases." Almost a decade later, the reason for this is no longer valid. This reverts commit 6620e74643e0baf040488557b1fff7273654a44d. Bug: https://bugs.gentoo.org/199722#c8 Acked-by: Zac Medico <zmedico@gentoo.org> Signed-off-by: Ulrich Müller <ulm@gentoo.org> bin/isolated-functions.sh | 3 +-- bin/phase-helpers.sh | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
A new aspect is that the planned introduction of a second argument for usev (see bug 744868) will make it inconsistent with hasv, where we obviously cannot have any such optional argument. OTOH, hasv is not used in the Gentoo repository, and was never used historically (except for a single _incorrect_ use in https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sci-libs/grib_api/grib_api-1.9.9.ebuild?hideattic=0&r1=1.1&r2=1.2). So we could go either for a ban of all three functions useq, hasq and hasv, or deprecate hasv in a similar way as it was done for useq and hasq. Reopening.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43cc36f055d6c4fd9c8761ecb50f57027180a1dd commit 43cc36f055d6c4fd9c8761ecb50f57027180a1dd Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2020-11-02 01:57:51 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-11-02 01:58:00 +0000 sys-apps/portage: Bump to version 3.0.9 #199722 Enable QA Notice for deprecated hasq/useq in *rm phases #704498 Fix pid-sandbox to handle Ctrl+Z correctly #752066 Add emerge --quickpkg-direct-root option #752147 Fix make.conf to expand special *ROOT variables #752153 Add @golang-rebuild package set Bug: https://bugs.gentoo.org/752168 Bug: https://bugs.gentoo.org/199722 Bug: https://bugs.gentoo.org/704498 Bug: https://bugs.gentoo.org/752066 Bug: https://bugs.gentoo.org/752147 Bug: https://bugs.gentoo.org/752153 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: Zac Medico <zmedico@gentoo.org> sys-apps/portage/Manifest | 1 + sys-apps/portage/portage-3.0.9.ebuild | 267 ++++++++++++++++++++++++++++++++++ 2 files changed, 268 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=7c8edfbb8001d447c6f02695954ed9e348dbd088 commit 7c8edfbb8001d447c6f02695954ed9e348dbd088 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2021-05-12 12:06:06 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2021-05-24 04:33:49 +0000 Ban hasq, hasv and useq in EAPI 8 Bug: https://bugs.gentoo.org/199722 Signed-off-by: Michał Górny <mgorny@gentoo.org> Signed-off-by: Zac Medico <zmedico@gentoo.org> bin/eapi.sh | 14 +++++++++++++- bin/isolated-functions.sh | 6 +++++- bin/phase-helpers.sh | 4 +++- 3 files changed, 21 insertions(+), 3 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/pms.git/commit/?id=70b5befa05d872c1aed119ab4e864d98d0a360d2 commit 70b5befa05d872c1aed119ab4e864d98d0a360d2 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2021-05-16 12:05:17 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2021-06-05 08:55:38 +0000 EAPI 8: useq, hasv and hasq are banned Bug: https://bugs.gentoo.org/199722 Signed-off-by: Ulrich Müller <ulm@gentoo.org> eapi-differences.tex | 11 +++++++++++ pkg-mgr-commands.tex | 16 ++++++++++++++++ 2 files changed, 27 insertions(+)
