Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199388 - sys-power/hibernate-script do not include optional RDEPEND on zenity/kdialog/kstart
Summary: sys-power/hibernate-script do not include optional RDEPEND on zenity/kdialog/...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Alon Bar-Lev (RETIRED)
Depends on:
Reported: 2007-11-16 19:59 UTC by Yang Zhao
Modified: 2007-11-19 16:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

RDEPEND on zenity of USE=gnome (hibernate-script_zenity.patch,446 bytes, patch)
2007-11-16 20:02 UTC, Yang Zhao
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yang Zhao 2007-11-16 19:59:14 UTC
the xstatus module for hibernate-script, when configured to use gnome or kde, depends the appropriate dialog-displaying apps being installed.

This is not reflected in the ebuild, and can result in unexpected behaviours for users that decide to use those features without the full Gnome/KDE suite installed.
Comment 1 Yang Zhao 2007-11-16 20:02:13 UTC
Created attachment 136106 [details, diff]
RDEPEND on zenity of USE=gnome

This patch for hibernate-script-1.97-r1.ebuild adds RDEPEND on zenity if USE=gnome is set.

The counterpart for KDE is not included as I am not familiar with it, and do not have the appropriate apps installed.
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2007-11-16 22:43:05 UTC
As I replied in bug#198962:

Well, this would be difficult... As you may select by configuration to use
whatever N different utilities... I cannot make all dependency of
hibernate-script... I tried to add gnome USE flag now, this suggests adding KDE
USE flag too, which in turn fbsplash, then you pull some utilities of gnome
even if you use OSD, and we have a lot of different scriptlets that requires
even more utilities if used. So the simplest way is to install the utilities
you actually use.

Comment 3 Yang Zhao 2007-11-16 23:13:09 UTC
That's fair.

In that case, can we improve the elog to be slightly more explicit about what packages are needed for which feature? I run a xfce4 system with USE=gnome set to use certain specific gnome tools, but was caught by surprise when hibernate-script would fail with xstatus set to gnome as zenity was not pulled in.

In anycase, I'm closing this. Thanks.
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2007-11-17 07:36:14 UTC
Added some comments in common.conf.
Comment 5 Yang Zhao 2007-11-19 16:49:30 UTC
Looks good--thanks.

Closing bug.