Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199344 - dev-libs/clearsilver-0.10.5 crc test fails on amd64
Summary: dev-libs/clearsilver-0.10.5 crc test fails on amd64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: AMD64 Linux
: High trivial (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 203584
  Show dependency tree
 
Reported: 2007-11-16 11:14 UTC by Sylvain BERTRAND
Modified: 2012-02-10 14:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch adding test crc patch for amd64 (clearsilver-0.10.5.ebuild.patch,398 bytes, patch)
2007-11-16 11:17 UTC, Sylvain BERTRAND
Details | Diff
test_crc patch (clearsilver-0.10.5-test_crc.patch,404 bytes, patch)
2007-11-16 11:17 UTC, Sylvain BERTRAND
Details | Diff
Fix the crc "wrap-around" problem on amd64 machines (clearsilver-0.10.5-csparse_crc.patch,619 bytes, patch)
2008-04-30 18:45 UTC, Tom Regner
Details | Diff
patch clearsilver-0.10.5 to apply csparse_crc patch on amd64 machines (clearsilver-0.10.5-ebuild.csparse.patch,397 bytes, patch)
2008-04-30 18:48 UTC, Tom Regner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain BERTRAND 2007-11-16 11:14:03 UTC
The crc test does not deal properly with 64 bits machines where the int is 32bits and the long is 64bits.
Comment 1 Sylvain BERTRAND 2007-11-16 11:17:11 UTC
Created attachment 136080 [details, diff]
ebuild patch adding test crc patch for amd64
Comment 2 Sylvain BERTRAND 2007-11-16 11:17:37 UTC
Created attachment 136081 [details, diff]
test_crc patch
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2007-12-30 12:25:28 UTC
Looks to be a workaround instead of a fix. Has upstream been informed?
Comment 4 Sylvain BERTRAND 2007-12-30 18:51:32 UTC
Yes, have a look at the mailing list archive (if any...).
They "said" it's no matter of importance
Comment 5 Tom Regner 2008-04-30 18:43:42 UTC
I took a look under the hood, and all that's missing seems to be a cast to INT32 in cs/csparse.c to prevent the result to not "wrap around" as expected.

The test passes with htis patch applied.

I tested that clearsilver still works with pike/Public.Parser.ClearSilver.

I attach a patch (clearsilver-0.10.5-csparse_crc.patch) and basically the same patch to the ebuild as Sylvain provided with just the patch-name changed.

regards,
tom
Comment 6 Tom Regner 2008-04-30 18:45:10 UTC
Created attachment 151456 [details, diff]
Fix the crc "wrap-around" problem on amd64 machines
Comment 7 Tom Regner 2008-04-30 18:48:52 UTC
Created attachment 151458 [details, diff]
patch clearsilver-0.10.5 to apply csparse_crc patch on amd64 machines
Comment 8 Tom Regner 2008-04-30 19:05:15 UTC
I sent the same patch to upstream (the clearsilver mailinglist at yahoo) - maybe there is a problem  with this simple cast I don't see.
Comment 9 Sylvain BERTRAND 2008-05-13 10:27:25 UTC
Are patches ok to go in?
Comment 10 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-12-20 22:14:07 UTC
@web-apps team: Please advise.
Comment 11 Agostino Sarubbo gentoo-dev 2011-12-15 17:02:52 UTC
Re-add amd64 if we need us.
Comment 12 Sylvain BERTRAND 2012-02-10 14:20:59 UTC
the test fails but installation is successfull