Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199294 - app-emulation/mol-0.9.72.1 does not build due to missing ioctl include
Summary: app-emulation/mol-0.9.72.1 does not build due to missing ioctl include
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: PPC Linux
: High normal (vote)
Assignee: Joe Jezak (RETIRED)
URL:
Whiteboard: Pending Removal: 2012-12-24
Keywords: PMASKED
: 270403 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-11-15 20:29 UTC by Florian Fainelli
Modified: 2012-12-25 12:59 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ioctl definition for src/kmod/misc.c (mol-0.9.72.1-ioctl-def.patch,340 bytes, patch)
2007-11-15 20:30 UTC, Florian Fainelli
Details | Diff
Patch to the ebuild to apply the previously sent patch (mol-patch-ioctl.diff,332 bytes, patch)
2007-11-15 20:31 UTC, Florian Fainelli
Details | Diff
for mol-0.9.72.1 with kernels >= 2.6.23 (mol-0.9.72.1-2.6.23.patch,6.12 KB, patch)
2008-11-11 15:48 UTC, Didier Cardoso
Details | Diff
some fixes for mol-0.9.72.1 (mol-0.9.72.1-misc.patch,2.57 KB, patch)
2008-11-11 15:51 UTC, Didier Cardoso
Details | Diff
Patch to the ebuild to apply the 2 previously sent patches (mol-0.9.72.1-ebuild.diff,431 bytes, patch)
2008-11-11 16:12 UTC, Didier Cardoso
Details | Diff
build.log of mol-0.9.72.1.ebuild w/ last 2 patches (build.log,22.97 KB, text/plain)
2008-12-11 14:18 UTC, hiyuh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Fainelli 2007-11-15 20:29:53 UTC
mol-0.9.72.1 fails building on my ibook g4 with the following use flags :

USE="X alsa debug dga fbcon oss pci sheep usb -oldworld -vnc"

fails with the following error message :

 CC [M]  /var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.o
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c: In function 'handle_ioctl':
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:182: error: implicit declaration of function '_IOWR'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:182: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:182: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:186: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:186: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:190: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:190: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:195: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:195: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:198: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:198: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:202: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:202: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:205: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:205: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:209: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:209: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:212: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:212: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:216: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:216: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:227: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:227: error: case label does not reduce to an integer constant
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:246: error: expected expression before 'mol_ioctl_pb_t'
/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.c:246: error: case label does not reduce to an integer constant
make[2]: *** [/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod/misc.o] Error 1
make[1]: *** [_module_/var/tmp/portage/app-emulation/mol-0.9.72.1/work/mol-0.9.72.1/obj-ppc/build/src/kmod] Error 2
nm: '../../../obj-ppc/build/src/kmod/Linux/..//mol.ko': No such file
nm: '../../../obj-ppc/build/src/kmod/Linux/..//mol.ko': No such file
checker.pl failed
rm: cannot remove `../../../obj-ppc/build/src/kmod/Linux/..//mol.ko': No such file or directory
make: *** [all-local] Error 1
 *
 * ERROR: app-emulation/mol-0.9.72.1 failed.
 * Call stack:
 *             ebuild.sh, line 1701:  Called dyn_compile
 *             ebuild.sh, line 1039:  Called qa_call 'src_compile'
 *             ebuild.sh, line   44:  Called src_compile
 *   mol-0.9.72.1.ebuild, line   81:  Called linux-mod_src_compile
 *      linux-mod.eclass, line  518:  Called die
 * The specific snippet of code:
 *                      emake HOSTCC="$(tc-getBUILD_CC)" CC="$(get-KERNEL_CC)" LDFLAGS="$(get_abi_LDFLAGS)" \
 *                                ${BUILD_FIXES} ${BUILD_PARAMS} ${BUILD_TARGETS} \
 *                              || die "Unable to make ${BUILD_FIXES} ${BUILD_PARAMS} ${BUILD_TARGETS}."
 *  The die message:
 *   Unable to make  TOUT=/var/tmp/portage/app-emulation/mol-0.9.72.1/temp/.tmp_gas_check TOUT=/var/tmp/portage/app-emulation/mol-0.9.72.1/temp/.tmp_gas_check TOUT=/var/tmp/portage/app-emulation/mol-0.9.72.1/temp/.tmp_gas_check KERNEL_SOURCE=/usr/src/linux LV=26 MP=ko
                                  KUNAME=2.6.23-gentoo all.

Reproducible: Always
Comment 1 Florian Fainelli 2007-11-15 20:30:35 UTC
Created attachment 136060 [details, diff]
ioctl definition for src/kmod/misc.c

This patch fixes the include, though I am unsure of the proper location of the include.
Comment 2 Florian Fainelli 2007-11-15 20:31:35 UTC
Created attachment 136062 [details, diff]
Patch to the ebuild to apply the previously sent patch

This patch makes the ebuild apply the ioctl patch sent before.
Comment 3 lordcris 2008-02-12 16:57:58 UTC
could you include a patch for the 2.6.24 kernel?
tnx
Comment 4 Joe Jezak (RETIRED) gentoo-dev 2008-04-05 21:39:09 UTC
This fix has been in the MOL svn for a while, but to use MOL on newer kernels, you'll also need a kernel patch.  This patch is available on the MOL bugzilla.
Comment 5 Didier Cardoso 2008-11-11 15:48:15 UTC
Created attachment 171429 [details, diff]
for mol-0.9.72.1 with kernels >= 2.6.23
Comment 6 Didier Cardoso 2008-11-11 15:51:16 UTC
Created attachment 171433 [details, diff]
some fixes for mol-0.9.72.1
Comment 7 Didier Cardoso 2008-11-11 16:12:06 UTC
Created attachment 171435 [details, diff]
Patch to the ebuild to apply the 2 previously sent patches

For kernels >= 2.6.23 , don't forget to apply the mm_fault patch on your kernel sources :

http://dev.gentoo.org/~josejx/mol-mm.patch
Comment 8 hiyuh 2008-12-11 14:18:22 UTC
Created attachment 174958 [details]
build.log of mol-0.9.72.1.ebuild w/ last 2 patches

mol-0.9.72.1.ebuild w/ last 2 patches failed to compile for me.
Comment 9 Alex Buell 2009-03-06 14:21:39 UTC
The reason why 0.9.72.1 fails to build with kernels 2.6.27+ is that the arch has changed from ppc to powerpc. If you fix that, it will build just fine. 
Comment 10 daktak 2009-10-14 22:22:00 UTC
I followed http://forums.gentoo.org/viewtopic-t-756440-highlight-mol.html

Would it be worth adding somthing like this to the ebuild?
if ! test -d /usr/src/linux/arch/ppc; then
 eerror "Please create link from arch/powerpc as below"
 eerror "ln -s /usr/src/linux/arch/powerpc usr/src/linux/arch/ppc"
 die "Failed prerequisite"
fi
Comment 11 daktak 2009-11-01 01:26:35 UTC
It compiles but the module wont insert with 2.6.30 
mol: Unknown symbol handle_mm_fault
Comment 12 Joe Jezak (RETIRED) gentoo-dev 2010-02-10 05:45:45 UTC
Sorry, I've kind of let MOL fall aside since a kernel dev removed the export for symbols that MOL uses, but it can be fixed if someone has the need and time to do so.
Comment 13 Joe Jezak (RETIRED) gentoo-dev 2010-02-10 05:46:20 UTC
*** Bug 270403 has been marked as a duplicate of this bug. ***
Comment 14 Mark Loeser (RETIRED) gentoo-dev 2010-02-12 16:00:48 UTC
(In reply to comment #12)
> Sorry, I've kind of let MOL fall aside since a kernel dev removed the export
> for symbols that MOL uses, but it can be fixed if someone has the need and time
> to do so.
> 

It also has a broken dep tree now due to net-misc/vnc being masked.  Is this package going to be fixed or should we just package.mask it?  If its going to be fixed, I'll remove the use flag to fix the deps.
Comment 15 Joe Jezak (RETIRED) gentoo-dev 2010-02-12 18:58:32 UTC
I've masked MOL for now, if anyone wants to help fix it up, please let us know.
Comment 16 Pacho Ramos gentoo-dev 2012-10-06 12:33:59 UTC
Probably a candidate for treecleaning
Comment 17 Pacho Ramos gentoo-dev 2012-12-25 12:59:37 UTC
dropped