Bug 194267 – x11-libs/qt-4.x: PNG support not build

• Status: VERIFIED NEEDINFO
• Product: Gentoo Linux

[Description thereapman 2007-09-30 11:19:35 UTC]

The PNG useflag of x11-libs/qt-4.x did not activate png-support even is it set.
Ther is no check for that flag in the ebuild. 

I've attached a fixed ebuild that will build png-support against the system libpng, when the png flag is set.

Reproducible: Always

Steps to Reproduce:

[Comment 1 thereapman 2007-09-30 11:20:21 UTC]

Created attachment 132229 [details]
The fixed Ebuild

[Comment 2 Jakub Moc (RETIRED) 2007-09-30 13:47:10 UTC]

Please, reopen with a unified diff against qt-4.3.1-r1

[Comment 3 Jakub Moc (RETIRED) 2007-09-30 13:47:23 UTC]

Wrong resolution.

[Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2007-09-30 16:11:11 UTC]

(In reply to comment #0)
> Ther is no check for that flag in the ebuild. 

There is:
...
qt_use() {
    local flag="$1"
    local feature="$1"
    local enableval=

    [[ -n $2 ]] && feature=$2
    [[ -n $3 ]] && enableval="-$3"

    useq $flag && echo "${enableval}-${feature}" || echo "-no-${feature}"
    return 0
}
...
myconf="${myconf} $(qt_use gif gif qt) $(qt_use png libpng system)"
...

(In reply to comment #3)
> Wrong resolution.

Still wrong. It should be INVALID.