Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 190006 - app-office/koffice-1.6.3: invalid desktop entries
Summary: app-office/koffice-1.6.3: invalid desktop entries
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Gentoo KDE team
: 197113 (view as bug list)
Depends on:
Blocks: 189364
  Show dependency tree
Reported: 2007-08-24 07:59 UTC by Martin von Gagern
Modified: 2009-05-27 09:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Ebuild diff for app-portage/kexi-1.6.3 to fix the desktop file. (diff,432 bytes, patch)
2007-08-26 12:49 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff
Karbon patch (diff,353 bytes, patch)
2007-08-26 13:34 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff
Patch for Kformula (diff,373 bytes, patch)
2007-08-26 22:45 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff
Patch for Kword (diff,315 bytes, patch)
2007-08-27 00:09 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff
Patch for Krita (diff,449 bytes, patch)
2007-08-27 12:52 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff
Patch for Kchart (diff,381 bytes, patch)
2007-08-27 13:17 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff
Patch for Kivio (diff,368 bytes, patch)
2007-08-27 21:27 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2007-08-24 07:59:17 UTC
After remerging kexi, I got an elog mail:

/usr/share/applications/kde/kexi.desktop: value "application/x-kexiproject-sqlite;application/x-sqlite2;application/x-kexiproject-shortcut;application/x-kexiproject-sqlite2;application/x-kexiproject-sqlite3;application/x-sqlite3;application/x-kexi-connectiondata;application/x-msaccess" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Checking all my desktop files, I found the following KOffice ebuilds had installed files containing errors:

Comment 1 Martin von Gagern 2007-08-24 08:41:32 UTC
As Jakub changed the Summary to give an explicit package name, I should say that I've got koffice-meta here, as you can probably tell from the above package list.
I would assume, however, that the single package would contain the same errors.
Comment 2 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-26 12:05:36 UTC
Ok, I am going to work on this bug, but I would prefer the input from some gentoo devs on the best way to go about it. Would it be best to sed the file? Or would a patch that is sendable to upstream be more appropriate? Either way I can do it, but the question of what type of fix to use is stopping me from fixing it. Thanks.
Comment 3 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-26 12:49:54 UTC
Created attachment 129236 [details, diff]
Ebuild diff for app-portage/kexi-1.6.3 to fix the desktop file.

I'll put patches for the others as I finish them
Comment 4 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-26 13:34:34 UTC
Created attachment 129238 [details, diff]
Karbon patch

I tested this one, Philantrop. :)
Comment 5 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-26 22:45:51 UTC
Created attachment 129268 [details, diff]
Patch for Kformula
Comment 6 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-27 00:09:58 UTC
Created attachment 129269 [details, diff]
Patch for Kword
Comment 7 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-27 12:52:38 UTC
Created attachment 129319 [details, diff]
Patch for Krita

Thanks to kojiro for help with the regular expression.
Comment 8 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-27 13:17:18 UTC
Created attachment 129321 [details, diff]
Patch for Kchart
Comment 9 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-08-27 21:27:14 UTC
Created attachment 129377 [details, diff]
Patch for Kivio
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2007-10-26 09:33:04 UTC
*** Bug 197113 has been marked as a duplicate of this bug. ***
Comment 11 Carsten Lohrke (RETIRED) gentoo-dev 2009-02-09 01:44:14 UTC
With the 1.6.3_p20090204 ebuilds the desktop files are all fixed - at least to the degree it's possible, given that KDE's desktop files are not entirely standard compliant.

A general remark - a patch should always be preferred to sed expressions for at least two reasons: As a Gentoo dev we signed¹, that our fixes reach upstream and not doing so is bad practice. A sed expression is also to be avoided, because it may linger around in ebuilds/eclasses, even 
when it isn't needed anymore. Expensive QA work is the result. sed expressions are only to be used for inevitable dynamic changes, stuff not going upstream, like branding etc.. When you fix desktop files, please rerun desktop-file-validate yourself and fix the (suppressed) warnings as well.