Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 181718 - Please fix Emacs support in dev-util/git
Summary: Please fix Emacs support in dev-util/git
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Fernando J. Pereda (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 174469 184166
  Show dependency tree
 
Reported: 2007-06-12 06:59 UTC by Christian Faulhammer (RETIRED)
Modified: 2007-06-16 18:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
git-emacs.patch (git-emacs.patch,929 bytes, patch)
2007-06-12 07:01 UTC, Christian Faulhammer (RETIRED)
Details | Diff
71git-gentoo.el (71git-gentoo.el,126 bytes, text/plain)
2007-06-12 07:04 UTC, Christian Faulhammer (RETIRED)
Details
71git-gentoo.el (71git-gentoo.el,225 bytes, text/plain)
2007-06-12 08:29 UTC, Christian Faulhammer (RETIRED)
Details
71git-gentoo.el (71git-gentoo.el,265 bytes, text/plain)
2007-06-12 09:10 UTC, Christian Faulhammer (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Faulhammer (RETIRED) gentoo-dev 2007-06-12 06:59:53 UTC
You use some non-standard ways to install Emacs support files for git.  I will attach a patch for the latest ebuild and an corrected init file.
Comment 1 Christian Faulhammer (RETIRED) gentoo-dev 2007-06-12 07:01:37 UTC
Created attachment 121775 [details, diff]
git-emacs.patch

Correcting some "mistakes" in the ebuild
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2007-06-12 07:04:14 UTC
Created attachment 121776 [details]
71git-gentoo.el

new init file
Comment 3 Fernando J. Pereda (RETIRED) gentoo-dev 2007-06-12 07:53:40 UTC
---8<---
@@ -157,7 +157,5 @@
 }
 
 pkg_postrm() {
-	# regenerate site-gentoo if we are merged USE=emacs and unmerged
-	# USE=-emacs
-	has_version virtual/emacs && elisp-site-regen
+	use emacs && elisp-site-regen
 }
---8<---

I don't like this hunk. When removing a piece of code with a comment like that, please make sure you state WHY and how your new version is NOT affected by that comment.

- ferdy
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2007-06-12 07:56:21 UTC
(In reply to comment #2)
> Created an attachment (id=121776) [edit]
> 71git-gentoo.el

 Hold back a bit for that, as we are testing another solution, too.
Comment 5 Christian Faulhammer (RETIRED) gentoo-dev 2007-06-12 08:29:48 UTC
Created attachment 121779 [details]
71git-gentoo.el

> I don't like this hunk. When removing a piece of code with a comment like that,
> please make sure you state WHY and how your new version is NOT affected by that
> comment.

 The status of USE=emacs when unmerging is taken from the db, so even unsetting it between merge and unmerge has no effect.
 See new init file which uses some kind of autoload mechanism, making start-up of Emacs faster.
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2007-06-12 09:10:30 UTC
Created attachment 121782 [details]
71git-gentoo.el

Last try, promised
Comment 7 Fernando J. Pereda (RETIRED) gentoo-dev 2007-06-16 18:07:46 UTC
On 1.5.2.2, thanks.

- ferdy