Bug 180927 – sys-cluster/drbd-8.0.3 needs CONFIG_CONNECTOR enabled in kernel

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Evgeniy Kliymovich 2007-06-05 05:11:59 UTC]

Hi.

When CONFIG_CONNECTOR isn't set, build will fail:

/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c:33:2: error: #error "drbd backported connector.c compiled against kernel connector.h will not work"
/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c:34:2: error: #error "enable CONFIG_CONNECTOR in your kernel and try again"
/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c: In function ‘cn_call_callback’:
/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c:149: error: ‘struct work_struct’ has no member named ‘pending’
/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c:149: error: ‘struct work_struct’ has no member named ‘pending’
/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c:175: error: ‘struct work_struct’ has no member named ‘pending’
/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c:177: error: incompatible types in assignment
/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.c:178: error: ‘struct work_struct’ has no member named ‘timer’
make[3]: *** [/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd/connector.o] Error 1
make[2]: *** [_module_/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd] Error 2
make[2]: Leaving directory `/usr/src/linux-2.6.20-gentoo-r8'
make[1]: *** [kbuild] Error 2
make[1]: Leaving directory `/var/tmp/portage/sys-cluster/drbd-8.0.3/work/drbd-8.0.3/drbd'
make: *** [module] Error 2

!!! ERROR: sys-cluster/drbd-8.0.3 failed.
Call stack:
  ebuild.sh, line 1615:   Called dyn_compile
  ebuild.sh, line 972:   Called qa_call 'src_compile'
  ebuild.sh, line 44:   Called src_compile
  drbd-8.0.3.ebuild, line 45:   Called die


...that's don't show to user him mistake. I think that's bad. New ebuild must don't start build without CONFIG_CONNECTOR set in kernel config.

[Comment 1 Evgeniy Kliymovich 2007-06-05 05:13:37 UTC]

Created attachment 121216 [details, diff]
patch-for-drbd-8.0.3.ebuild

Patch for ebuild: drbd-8.0.3.ebuild

[Comment 2 Jakub Moc (RETIRED) 2007-06-05 06:09:17 UTC]

Comment on attachment 121216 [details, diff]
patch-for-drbd-8.0.3.ebuild

This patch is wrong; you need to use linux-info eclass properly to check for kernel features.

[Comment 3 Evgeniy Kliymovich 2007-06-05 16:35:09 UTC]

(In reply to comment #2)
> (From update of attachment 121216 [details, diff] [edit])
> This patch is wrong; you need to use linux-info eclass properly to check for
> kernel features.
> 

Yes, you right. Without gentoo slyle :).
Follow new patches...

[Comment 4 Evgeniy Kliymovich 2007-06-05 16:36:17 UTC]

Created attachment 121261 [details, diff]
patch-for-drbd-8.0.2-r1.ebuild

Patch for drbd-8.0.2-r1.ebuild

[Comment 5 Evgeniy Kliymovich 2007-06-05 16:36:51 UTC]

Created attachment 121262 [details, diff]
patch-for-drbd-8.0.3.ebuild

Patch for drbd-8.0.3.ebuild

[Comment 6 Evgeniy Kliymovich 2007-06-05 17:19:25 UTC]

Created attachment 121267 [details, diff]
patch-for-drbd-8.0.3.ebuild

[Comment 7 Christian Zoffoli (RETIRED) 2007-06-06 17:50:28 UTC]

Fixed in CVS, thanks.