Bug 179649 – games-fps/quake3-1.34_rc3 fails on gcc-4.2

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Philipp 2007-05-24 14:56:32 UTC]

The file code/tools/asm/cmdlib.c contains two expressions that always evaluate to true because it compares an array against true (which actually converts the array into a pointer to the first element) which must not be zero. Because -Werror is set and gcc-4.2 has stricter warnings the build fails.
I will attach a small patch to fix it.

Reproducible: Always

Steps to Reproduce:
1. switch to gcc-4.2
2. emerge quake3

[Comment 1 Philipp 2007-05-24 14:57:11 UTC]

Created attachment 120194 [details, diff]
Patch to fix the bug.

[Comment 2 Tristan Heaven (RETIRED) 2007-06-08 13:20:28 UTC]

I think it should be changed to do what was intended instead of removing it entirely.

[Comment 3 Chris Gianelloni (RETIRED) 2007-06-20 01:32:11 UTC]

I completely agree.  Also, upstream is very responsive with regards to bugs such as this, so any patches we apply will very likely be accepted upstream easily.

[Comment 4 SpanKY 2007-06-22 02:06:41 UTC]

i'd just say drop the -Werror from the build ... that only causes trouble

also, upstream has already accepted a bug fix from nyhm for this which ive added