Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 174063 - radeonfb patches for X800 PCIE cards
Summary: radeonfb patches for X800 PCIE cards
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-10 18:18 UTC by Jimmy.Jazz
Modified: 2007-09-02 22:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
radeon_monitor.c patch (radeon_monitor.c.2.6.20.diff,2.36 KB, patch)
2007-04-10 18:19 UTC, Jimmy.Jazz
Details | Diff
radeon_accel.c (radeon_accel.c.2.6.20.diff,1.31 KB, patch)
2007-04-10 18:20 UTC, Jimmy.Jazz
Details | Diff
ati_ids.h (ati_ids.h.2.6.20.diff,350 bytes, patch)
2007-04-11 11:41 UTC, Jimmy.Jazz
Details | Diff
radeon_base.c (radeon_base.c.2.6.20.diff,6.80 KB, patch)
2007-04-11 11:43 UTC, Jimmy.Jazz
Details | Diff
radeonfb.h (radeonfb.h.2.6.20.diff,889 bytes, patch)
2007-04-11 11:44 UTC, Jimmy.Jazz
Details | Diff
patch for 2.6.21 vanilla kernel (aty-2.6.21.diff,8.36 KB, patch)
2007-05-17 10:39 UTC, Jimmy.Jazz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy.Jazz 2007-04-10 18:18:41 UTC
Hello,

i own an ATI PCIE X800 card and was unable to use radeonfb at all. The flat panel didn't initialize and the display stays definitely black or goes immediately in standby mode.

I made two tiny patches to get the radeon console framebuffer working with that video card. I hope it works for a lot of cards and not just only for a pcie X800 card.

My 1680x1050 flat panel is now recognized at its native resolution and without forcing the video output to TMDS. Also i'm able to use gensplash as well.

Jj




Reproducible: Always




See attachments above
Comment 1 Jimmy.Jazz 2007-04-10 18:19:41 UTC
Created attachment 115919 [details, diff]
radeon_monitor.c patch
Comment 2 Jimmy.Jazz 2007-04-10 18:20:50 UTC
Created attachment 115921 [details, diff]
radeon_accel.c

Necessary to get dri working for the xorg server
Comment 3 Jimmy.Jazz 2007-04-10 18:22:09 UTC
The patches should work with 2.6.21 kernel as well
Comment 4 Jimmy.Jazz 2007-04-11 11:41:56 UTC
Created attachment 115962 [details, diff]
ati_ids.h
Comment 5 Jimmy.Jazz 2007-04-11 11:43:10 UTC
Created attachment 115963 [details, diff]
radeon_base.c

without it ATOM BIOS won't be detected
Comment 6 Jimmy.Jazz 2007-04-11 11:44:39 UTC
Created attachment 115964 [details, diff]
radeonfb.h
Comment 7 Jimmy.Jazz 2007-04-11 12:23:13 UTC
I checked twice and i think i added all the necessary patches this time to make to video card working. 

Indeed, you need to apply radeon_base.c, radeon_accel.c, radeon_monitor.c, radeonfb.h and ati_ids.h patches to the kernel.

Jj
Comment 8 Daniel Drake (RETIRED) gentoo-dev 2007-04-27 22:32:08 UTC
Thanks for the patches. Did you write them yourself?

If so, can you explain the information sources? It seems to touch upon some low-level aspects of this hardware.
Comment 9 Jimmy.Jazz 2007-05-02 20:38:39 UTC
(In reply to comment #8)
> Thanks for the patches. Did you write them yourself?
> 
> If so, can you explain the information sources? It seems to touch upon some
> low-level aspects of this hardware.
> 

Hello dsd,

unfortunately, it would be quite difficult for me to comment all these lines. I don't have special knowledge in videocards hardware.

The most i have done was to copy-paste xf86-video-ati in the different kernel files and to find out what was going wrong with my videocard. Most of the issues i have solved were: the kernel hardlock, the black screen when switching from x11 to the console, to make possible to use dri and to integrate monid among dvi connectors. I made as few modifications as possible in order not to mess the original kernel code too much.
Anyway if you are interested in a more complete version, that integrates more x11 codes (but takes more place in the kernel), i can send it to you.  That version is nearer from the one the maintainers have published. I have modified it to make it compatible with my videocard too.

Most of my work was around the ati atom bios integration.

My card is a genuine ATI card (indeed ! :)) and the display is an acer 1680x1050 flat screen connected to a dvi-i connector. As a remark, when the driver failed to probe the connector, it defaulted with a vga connector. That could explain why many ati cards work flawlessly, when others like mine won't ;).


Jj
Comment 10 Daniel Drake (RETIRED) gentoo-dev 2007-05-02 22:50:29 UTC
There are licensing issues when copying code from xf86-video-ati into the kernel. 

> Anyway if you are interested in a more complete version, that integrates more
> x11 codes (but takes more place in the kernel), i can send it to you.  That
> version is nearer from the one the maintainers have published. I have modified
> it to make it compatible with my videocard too.

Can you expand on this? Are you saying that there is an alternative patch not written by yourself which does almost the same thing?
Comment 11 Jimmy.Jazz 2007-05-03 13:42:38 UTC
(In reply to comment #10)
> There are licensing issues when copying code from xf86-video-ati into the
> kernel. 
> 

If i remember well the xf86-video-ati file is provided "as is".
Anyway, i prefer my own version of code. I have addressed the atom bios and got the PLL infos in the same manner as in radeon_bios.c xorg file.

> > Anyway if you are interested in a more complete version, that integrates more
> > x11 codes (but takes more place in the kernel), i can send it to you.  That
> > version is nearer from the one the maintainers have published. I have modified
> > it to make it compatible with my videocard too.
> 
> Can you expand on this? Are you saying that there is an alternative patch not
> written by yourself which does almost the same thing?
> 

You ask me rather strange questions. If you are interested, you will find them on the linux-fbdev-devel archive list,  http://lwn.net/Articles/215965/ or on 
http://search.gmane.org/?query=radeonfb+X800&author=&group=&sort=relevance&DEFAULTOP=and&xP=radeonfb%09x800&xFILTERS=--A

Moreover, it wouldn't be fair to say i have written them by myself. My own patches are basic patches over more difficult patches that belong to their respective owners :)

Anyway, it would be great to know if they are working for other people.

Jj
Comment 12 Daniel Drake (RETIRED) gentoo-dev 2007-05-17 01:45:13 UTC
(In reply to comment #11)
> If i remember well the xf86-video-ati file is provided "as is".

You're right, there are no issues here.

> You ask me rather strange questions. If you are interested, you will find them
> on the linux-fbdev-devel archive list,  http://lwn.net/Articles/215965/ or on 
> http://search.gmane.org/?query=radeonfb+X800&author=&group=&sort=relevance&DEFAULTOP=and&xP=radeonfb%09x800&xFILTERS=--A

Thanks. It's just important to know the origins of patches and to credit the appropriate people.

I'll follow this up upstream.
Comment 13 Jimmy.Jazz 2007-05-17 10:32:36 UTC
(In reply to comment #12) 
> Thanks. It's just important to know the origins of patches and to credit the
> appropriate people.
> 
> I'll follow this up upstream.
> 

I agree with you. As far as i know since 2005 the maintainer is benh@kernel.crashing.org but it seems to be a lot more unofficial co maintainers and i didn't find out who was the real initiator of radeon_accel.c for example. That code is really important if you want the kernel driver to work with x11. 
Anyway it is provided in the kernel, so it should be GPL.

I created an other diff file (aty-2.6.21.diff) for linux vanilla 2.6.21 kernel this time. There is even less modifications in it than ever :) If you follow the code upstream, this one will certainly be more appropriate. The patch will succeed without an hitch. 

In fact, most of the issues now come from the kernel driver unable to auto detect the monitor. It didn't check ddc_monid.


Comment 14 Jimmy.Jazz 2007-05-17 10:39:23 UTC
Created attachment 119507 [details, diff]
patch for 2.6.21 vanilla kernel

the patch is build for the 2.6.21 vanilla kernel. It should certainly work with the gentoo kernel 2.6.21 as well, but not with 2.6.20 series.
Comment 15 Daniel Drake (RETIRED) gentoo-dev 2007-07-10 13:18:21 UTC
Jimmy, have you made any progress upstream with these patches? Where do things stand now?
Comment 16 Maarten Bressers (RETIRED) gentoo-dev 2007-09-02 22:54:53 UTC
Closing this bug, if you have any further progress to report, please reopen it.