172594 – java-util-2.eclass: java-pkg_get-javac can't be called alone

Bug 172594 - java-util-2.eclass: java-pkg_get-javac can't be called alone

Summary: java-util-2.eclass: java-pkg_get-javac can't be called alone

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Java team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2007-03-28 20:46 UTC by Petteri Räty (RETIRED)
Modified:	2015-08-02 23:12 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Demo ebuild (bug-172594.ebuild,387 bytes, text/plain) 2015-07-29 00:16 UTC, Sebastian Pipping	Details
Patch to call java-pkg_init-compiler_ and die on errors rather than using stdout (java-utils-2-eclass--java-pkg_get-javac--init-and-die.patch,1009 bytes, patch) 2015-07-29 00:37 UTC, Sebastian Pipping	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Petteri Räty (RETIRED) gentoo-dev

2007-03-28 20:46:41 UTC

aria gnu-crypto # JAVA_PKG_FORCE_COMPILER="ecj-3.2" ebuild gnu-crypto-2.0.1-r2.ebuild digest unpack
<snip>
 * Could not find environment file for
>>> Source unpacked.

aria gnu-crypto # ebuild gnu-crypto-2.0.1-r2.ebuild digest unpack
<snip>
 * Could not find environment file for
>>> Source unpacked.

Code in ebuild:
    einfo $(java-pkg_get-javac)

The good thing is that nothing is using this function but that's probably why this hasn't been detected until now. It seems this function only works if you first call java-pkg_init-compiler_

Probably should add the java-pkg_init-compiler_ in init-vm or something.

Comment 1 Sebastian Pipping gentoo-dev

2015-07-29 00:16:52 UTC

Created attachment 407846 [details]
Demo ebuild

Confirming.

Comment 2 Sebastian Pipping gentoo-dev

2015-07-29 00:37:04 UTC

Created attachment 407848 [details, diff]
Patch to call java-pkg_init-compiler_ and die on errors rather than using stdout

Alternatively, we could die if GENTOO_COMPILER is unset.  Calling java-pkg_init-compiler_ seems nicer to me and I don't see problems with it.  Do you?

Comment 3 James Le Cuirot gentoo-dev

2015-08-02 23:12:33 UTC

Very timely, sping! I ran into this while dealing with bug #542700. I've merged this now with some additional simplifications.