Bug 172557 – dev-python/docutils tests/alltests.py python-2.5 incompatible

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ali Polatel (RETIRED) 2007-03-28 14:27:00 UTC]

This is fixed in svn. See:
http://permalink.gmane.org/gmane.text.docutils.devel/3838
http://svn.berlios.de/viewcvs/docutils/trunk/docutils/test/alltests.py?rev=4629&r1=4564&r2=4629

[Comment 1 Ali Polatel (RETIRED) 2007-03-28 14:27:56 UTC]

Created attachment 114782 [details, diff]
docutils-0.4-python-2.5-fix.patch

  Patch taken from svn.

[Comment 2 Rob Cakebread (RETIRED) 2007-03-29 17:28:22 UTC]

Created attachment 114876 [details]
Failure messages

Output log after patch with Python 2.5

[Comment 3 Rob Cakebread (RETIRED) 2007-03-29 17:30:45 UTC]

Thanks for the patch, Ali. It did keep the test from bombing out, but now seven tests fail with Python 2.5. (see 'Failure messages' attachment)

I tested the patch with Python 2.4 and all tests still pass, so there must be other issues with 2.5 still.

[Comment 4 Ali Polatel (RETIRED) 2007-03-29 20:51:53 UTC]

(In reply to comment #3)
> Thanks for the patch, Ali. It did keep the test from bombing out, but now seven
> tests fail with Python 2.5. (see 'Failure messages' attachment)
> 
> I tested the patch with Python 2.4 and all tests still pass, so there must be
> other issues with 2.5 still.
> 
  Yes, there are
  There are 7 tests failing caused by three scripts:
  test/test_parsers/test_rst/test_directives/test_contents.py
  test/test_parsers/test_rst/test_directives/test_images.py
  test/test_parsers/test_rst/test_directives/test_tables.py
  
 So I started checking svn logs to find messages about python 2.5 compatibility.

>> svn log -v -r4631 test/test_parsers/test_rst/test_directives
------------------------------------------------------------------------
r4631 | goodger | 2006-06-22 22:05:20 +0300 (Thu, 22 Jun 2006) | 1 line
Changed paths:
   M /trunk/docutils/test/test_parsers/test_rst/test_directives/test_contents.py
   M /trunk/docutils/test/test_parsers/test_rst/test_directives/test_images.py
   M /trunk/docutils/test/test_parsers/test_rst/test_directives/test_tables.py

Python 2.5 compatibility: dynamic exception matching
------------------------------------------------------------------------
  
 However updating those three files from svn didn't make all tests succeed.There were still some failures caused by test_tables.py. So I kept on searching and found that docutils/parsers/rst/directives/tables.py has also been modified for python 2.5 compatibility:
>> svn log -v -r4630
------------------------------------------------------------------------
r4630 | goodger | 2006-06-22 22:04:01 +0300 (Thu, 22 Jun 2006) | 1 line
Changed paths:
   M /trunk/docutils/docutils/parsers/rst/directives/tables.py

for compatibility with Python2.5b1
------------------------------------------------------------------------

 Updating these 4 files from svn makes all tests succeed.
  
  

[Comment 5 Ali Polatel (RETIRED) 2007-03-29 20:58:55 UTC]

Created attachment 114891 [details, diff]
docutils-0.4-py-2.5-fix.patch

svn diff -r 4628:4631 > docutils-0.4-py-2.5-fix.patch

 With this patch all tests work fine here.

[Comment 6 Rob Cakebread (RETIRED) 2007-04-04 18:30:05 UTC]

Thanks Ali, added to CVS.
I tested the new patch with Python 2.4.4 and 2.5 and all tests pass now.