171272 – dohtml doesn't support simple quotes in filenames

Bug 171272 - dohtml doesn't support simple quotes in filenames

Summary: dohtml doesn't support simple quotes in filenames

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core - Ebuild Support (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	194041
	Show dependency tree

Reported:	2007-03-17 18:22 UTC by TGL
Modified:	2007-10-13 20:16 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
dohtml--simple_quote_in_filenames.patch (dohtml--simple_quote_in_filenames.patch,459 bytes, patch) 2007-03-17 18:23 UTC, TGL	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description TGL 2007-03-17 18:22:48 UTC

While writing an ebuild today, i've seen that dohtml doesn't support filenames which include some simple quote.  Ok, it's unusual, but in some contextes (ocaml generated doc here), it happens:

   install: missing destination file operand after `ocamldoc/code_VALConj.Make.conj_elt.html /var/tmp/portage/dev-ml/logfun-1.3/image/usr/share/doc/logfun-1.3/html///code_VALConj.Make.conj_elt.html'
  Try `install --help' for more information.
  ...

(the filename actually being "code_VALConj.Make.conj_elt'.html")

The attached patch for dohtml uses os.spawnlp() instead of os.system(), which avoids this kind of shell issues.

Comment 1 TGL 2007-03-17 18:23:34 UTC

Created attachment 113597 [details, diff]
dohtml--simple_quote_in_filenames.patch

Patch done against portage-2.1.2.2.

Comment 2 Zac Medico gentoo-dev

2007-10-13 20:16:25 UTC

Thanks, this has been released in 2.1.3.13.